Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model, cache, http): add support for polls #2341

Merged
merged 8 commits into from
Jul 13, 2024
Merged

feat(model, cache, http): add support for polls #2341

merged 8 commits into from
Jul 13, 2024

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni self-assigned this May 12, 2024
@github-actions github-actions bot added c-cache Affects the cache crate c-gateway Affects the gateway crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-model Affects the model crate c-standby Affects the standby crate t-feature Addition of a new feature labels May 12, 2024
@suneettipirneni suneettipirneni requested a review from a team May 12, 2024 18:02
Erk-
Erk- requested changes May 14, 2024
View reviewed changes
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some stuff here and there, but the overall view is pretty good.

twilight-model/src/poll/media.rs Show resolved Hide resolved
twilight-model/src/poll/media.rs Show resolved Hide resolved
twilight-model/src/poll/media.rs Show resolved Hide resolved
twilight-model/src/poll/answer_count.rs Outdated Show resolved Hide resolved
twilight-model/src/poll/answer_count.rs Outdated Show resolved Hide resolved
twilight-model/src/gateway/payload/incoming/message_poll_vote_remove.rs Outdated Show resolved Hide resolved
twilight-model/src/gateway/payload/incoming/message_poll_vote_remove.rs Outdated Show resolved Hide resolved
twilight-model/src/gateway/payload/incoming/message_poll_vote_add.rs Outdated Show resolved Hide resolved
twilight-model/src/gateway/payload/incoming/message_poll_vote_add.rs Outdated Show resolved Hide resolved
twilight-http/src/routing.rs Outdated Show resolved Hide resolved
Erk-
Erk- requested changes May 15, 2024
View reviewed changes
twilight-http/src/routing.rs Outdated Show resolved Hide resolved
@suneettipirneni suneettipirneni requested a review from Erk- May 15, 2024 17:10
@Erk- Erk- mentioned this pull request May 20, 2024
Merged
HTGAzureX1212
HTGAzureX1212 reviewed May 31, 2024
View reviewed changes
Copy link
Contributor

@HTGAzureX1212 HTGAzureX1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will approve once merge conflicts are resolved.

@suneettipirneni suneettipirneni enabled auto-merge (squash) July 13, 2024 01:57
@suneettipirneni suneettipirneni merged commit f660fd8 into main Jul 13, 2024
9 checks passed
@suneettipirneni suneettipirneni deleted the feat/polls branch July 13, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Erk- Erk- Erk- approved these changes

@AEnterprise AEnterprise AEnterprise approved these changes

@HTGAzureX1212 HTGAzureX1212 Awaiting requested review from HTGAzureX1212

Assignees

@suneettipirneni suneettipirneni

Labels
c-cache Affects the cache crate c-gateway Affects the gateway crate c-http Affects the http crate c-http-ratelimiting Affects the http ratelimiting crate c-model Affects the model crate c-standby Affects the standby crate t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suneettipirneni @Erk- @AEnterprise @HTGAzureX1212