Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(model, http)!: Add support for super reaction types #2347

Merged
merged 4 commits into from
Jul 13, 2024
Merged

feat(model, http)!: Add support for super reaction types #2347

merged 4 commits into from
Jul 13, 2024

Conversation

suneettipirneni
Copy link
Member

Refs:

This PR renames the old ReactionType to EmojiReactionType as the concept of a reaction type now exists in the API.

@suneettipirneni suneettipirneni requested a review from a team May 16, 2024 03:39
@suneettipirneni suneettipirneni self-assigned this May 16, 2024
@github-actions github-actions bot added c-cache Affects the cache crate c-http Affects the http crate c-model Affects the model crate c-standby Affects the standby crate c-validate Affects the validate crate m-breaking change Breaks the public API. t-feature Addition of a new feature labels May 16, 2024
Erk-
Erk- requested changes May 20, 2024
View reviewed changes
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small issues otherwise it looks good.

twilight-http/src/routing.rs Outdated Show resolved Hide resolved
twilight-model/src/channel/message/reaction_type.rs Show resolved Hide resolved
Erk-
Erk- approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@Erk- Erk- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it here, then lets fix the query string issue in #2348.

@suneettipirneni suneettipirneni requested a review from Erk- June 1, 2024 17:21
@suneettipirneni suneettipirneni merged commit c9e8013 into main Jul 13, 2024
9 checks passed
@suneettipirneni suneettipirneni deleted the feat/super-reaction-types branch July 13, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AEnterprise AEnterprise AEnterprise approved these changes

@Erk- Erk- Erk- approved these changes

@laralove143 laralove143 Awaiting requested review from laralove143

Assignees

@suneettipirneni suneettipirneni

Labels
c-cache Affects the cache crate c-http Affects the http crate c-model Affects the model crate c-standby Affects the standby crate c-validate Affects the validate crate m-breaking change Breaks the public API. t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suneettipirneni @Erk- @AEnterprise @laralove143