-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(model)!: gateway::event
reimagination
#2024
Draft
vilgotf
wants to merge
3
commits into
next
Choose a base branch
from
vilgotf/refactor/model/rework-event
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilgotf
added
c-gateway
Affects the gateway crate
c-model
Affects the model crate
m-breaking change
Breaks the public API.
t-refactor
Refactors APIs or code.
labels
Dec 31, 2022
vilgotf
force-pushed
the
vilgotf/refactor/model/rework-event
branch
3 times, most recently
from
January 9, 2023 04:40
2a7a09f
to
2868443
Compare
vilgotf
force-pushed
the
vilgotf/refactor/model/rework-event
branch
2 times, most recently
from
January 14, 2023 13:28
298a989
to
c148b22
Compare
7596ff
pushed a commit
that referenced
this pull request
Jan 28, 2023
Fixes the broken [`EventTypeFlags`] intralinks and rewords the docs to be slightly more consice. Moved out of #2024. [`EventTypeFlags`]: https://docs.rs/twilight-gateway/0.15.0-rc.2/twilight_gateway/struct.EventTypeFlags.html
vilgotf
force-pushed
the
vilgotf/refactor/model/rework-event
branch
from
February 6, 2023 09:41
c148b22
to
eabd8df
Compare
vilgotf
changed the title
Reimagine
refactor(model)!: Feb 6, 2023
Event
related typesgateway::event
reimagination
zeylahellyer
pushed a commit
that referenced
this pull request
Feb 17, 2023
Add methods to the gateway opcode model for determining whether an opcode is intended to be sent or received, represented by new `is_received` and `is_sent` methods. Documentation has been added to note what opcodes are in each category. This pull request was split out of #2024.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c-gateway
Affects the gateway crate
c-model
Affects the model crate
m-breaking change
Breaks the public API.
t-refactor
Refactors APIs or code.
w-do-not-merge
PR is blocked or deferred
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP reimagination of
gateway::event
.