Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(model)!: gateway::event reimagination #2024

Draft
wants to merge 3 commits into
base: next
Choose a base branch
from

Conversation

vilgotf
Copy link
Member

@vilgotf vilgotf commented Dec 31, 2022

WIP reimagination of gateway::event.

@vilgotf vilgotf added c-gateway Affects the gateway crate c-model Affects the model crate m-breaking change Breaks the public API. t-refactor Refactors APIs or code. labels Dec 31, 2022
Base automatically changed from vilgotf/refactor/model/unify-event-de to next January 6, 2023 23:22
@vilgotf vilgotf force-pushed the vilgotf/refactor/model/rework-event branch 3 times, most recently from 2a7a09f to 2868443 Compare January 9, 2023 04:40
@vilgotf vilgotf force-pushed the vilgotf/refactor/model/rework-event branch 2 times, most recently from 298a989 to c148b22 Compare January 14, 2023 13:28
7596ff pushed a commit that referenced this pull request Jan 28, 2023
Fixes the broken [`EventTypeFlags`] intralinks and rewords the docs to
be slightly more consice.

Moved out of #2024.

[`EventTypeFlags`]: https://docs.rs/twilight-gateway/0.15.0-rc.2/twilight_gateway/struct.EventTypeFlags.html
@zeylahellyer zeylahellyer added the w-do-not-merge PR is blocked or deferred label Feb 4, 2023
@vilgotf vilgotf force-pushed the vilgotf/refactor/model/rework-event branch from c148b22 to eabd8df Compare February 6, 2023 09:41
@vilgotf vilgotf changed the title Reimagine Event related types refactor(model)!: gateway::event reimagination Feb 6, 2023
zeylahellyer pushed a commit that referenced this pull request Feb 17, 2023
Add methods to the gateway opcode model for determining whether an
opcode is intended to be sent or received, represented by new
`is_received` and `is_sent` methods. Documentation has been added to
note what opcodes are in each category.

This pull request was split out of #2024.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-gateway Affects the gateway crate c-model Affects the model crate m-breaking change Breaks the public API. t-refactor Refactors APIs or code. w-do-not-merge PR is blocked or deferred
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants