feat(model): gateway OpCode sent/received categorization #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilgotf
added
t-feature
zeylahellyer
approved these changes
Feb 9, 2023
twilight-model/src/gateway/opcode.rs
Outdated
Comment on lines
5
to
21
| /// # Received by the client | ||
| /// | ||
| /// [`PresenceUpdate`], [`RequestGuildMembers`], and [`VoiceStateUpdate`] are | ||
| /// not requiried for establishing or maintaining a gateway connection. | ||
| /// * [`Dispatch`] | ||
| /// * [`Heartbeat`] | ||
| /// * [`HeartbeatAck`] | ||
| /// * [`Hello`] | ||
| /// * [`InvalidSession`] | ||
| /// * [`Reconnect`] | ||
| /// | ||
| /// # Sent by the client | ||
| /// | ||
| /// * [`Heartbeat`] | ||
| /// * [`Identify`] | ||
| /// * [`PresenceUpdate`] | ||
| /// * [`Resume`] | ||
| /// * [`RequestGuildMembers`] | ||
| /// * [`VoiceStateUpdate`] |
There was a problem hiding this comment.
Perhaps it would be better to document these directly on the methods?
7596ff
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents and add methods for the sent/received categorization of
OpCode.Split out of #2024