-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle relative symbolic links #98
Open
KaiOelfke
wants to merge
7
commits into
tuist:main
Choose a base branch
from
KaiOelfke:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
3212fff
add func to create symbolic link with RelativePath as destination
KaiOelfke 31f3496
add failing test with relative sym link
KaiOelfke e3f9d66
fix handling of relative symbolic link
KaiOelfke f26bb33
formatting
KaiOelfke f4cb1f7
Merge branch 'main' of github.com:KaiOelfke/FileSystem
KaiOelfke e963a81
add createSymbolicLink with RelativePath to FileSysteming protocol
KaiOelfke 09ade56
add private helper func for creating symbolic links with absolute and…
KaiOelfke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -549,6 +549,14 @@ public struct FileSystem: FileSysteming, Sendable { | |
) | ||
} | ||
|
||
public func createSymbolicLink(from: AbsolutePath, to: RelativePath) async throws { | ||
logger?.debug("Creating symbolic link from \(from.pathString) to \(to.pathString).") | ||
try await NIOFileSystem.FileSystem.shared.createSymbolicLink( | ||
at: FilePath(from.pathString), | ||
withDestination: FilePath(to.pathString) | ||
) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you think about creating a private helper method to combine the two private func createSymbolicLink(fromPathString: String, toPathString: String) async throws {
logger?.debug("Creating symbolic link from \(fromPathString) to \(toPathString).")
try await NIOFileSystem.FileSystem.shared.createSymbolicLink(
at: FilePath(fromPathString),
withDestination: FilePath(toPathString)
)
}
public func createSymbolicLink(from: AbsolutePath, to: AbsolutePath) async throws {
try await createSymbolicLink(fromPathString: from.pathString, toPathString: to.pathString)
} |
||
} | ||
|
||
public func resolveSymbolicLink(_ symlinkPath: AbsolutePath) async throws -> AbsolutePath { | ||
logger?.debug("Resolving symbolink link at path \(symlinkPath.pathString).") | ||
if !(try await exists(symlinkPath)) { | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to add the method to the
FileSysteming
protocol.