feat: handle relative symbolic links #98
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortmarek
approved these changes
Dec 20, 2024
| @@ -549,6 +549,14 @@ public struct FileSystem: FileSysteming, Sendable { | |||
| ) | |||
| } | |||
|
|
|||
| public func createSymbolicLink(from: AbsolutePath, to: RelativePath) async throws { | |||
There was a problem hiding this comment.
You will need to add the method to the FileSysteming protocol.
Sources/FileSystem/FileSystem.swift
Outdated
Comment on lines
553
to
557
| logger?.debug("Creating symbolic link from \(from.pathString) to \(to.pathString).") | ||
| try await NIOFileSystem.FileSystem.shared.createSymbolicLink( | ||
| at: FilePath(from.pathString), | ||
| withDestination: FilePath(to.pathString) | ||
| ) |
There was a problem hiding this comment.
What do you think about creating a private helper method to combine the two createSymbolicLink methods?
private func createSymbolicLink(fromPathString: String, toPathString: String) async throws {
logger?.debug("Creating symbolic link from \(fromPathString) to \(toPathString).")
try await NIOFileSystem.FileSystem.shared.createSymbolicLink(
at: FilePath(fromPathString),
withDestination: FilePath(toPathString)
)
}
public func createSymbolicLink(from: AbsolutePath, to: AbsolutePath) async throws {
try await createSymbolicLink(fromPathString: from.pathString, toPathString: to.pathString)
}
fortmarek
changed the title
fortmarek
changed the title
I made these changes. You can have another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix tuist/tuist#7145. There may be other or better ways to fix this. But the root issue seems to be handling of an relative symbolic link.