Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download latest released models #28

Merged
merged 2 commits into from
Mar 9, 2019
Merged

Conversation

ar13pit
Copy link
Contributor

@ar13pit ar13pit commented Mar 7, 2019

No description provided.

@ar13pit
Copy link
Contributor Author

ar13pit commented Mar 7, 2019

@MatthijsBurgh I can't wait for tue-robotics/tue-env#377 to be merged before finishing up this system. So I have opened an issue to generalize the path dirs after the merge in tue-env.

@ar13pit
Copy link
Contributor Author

ar13pit commented Mar 8, 2019

@MatthijsBurgh review please

@@ -0,0 +1,16 @@
#! /usr/bin/env bash

url=$(curl -s https://api.github.com/repos/tue-robotics/speech_recognition/releases/latest | \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check ros-dashboard target, it uses some python to do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is pretty much the same. Here I am specifying the version to always be the latest one while there it takes a version as an argument and searches over all the versions.

What do you want me to do? That's an overkill for what I am doing here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, but it uses json in python is cleaner IMO.

@ar13pit
Copy link
Contributor Author

ar13pit commented Mar 9, 2019

@MatthijsBurgh Change to python for parsing the github releases added as a issue #30 . For now lets merge this unless you feel there is an error somewhere in the script.

@MatthijsBurgh MatthijsBurgh merged commit d98e583 into master Mar 9, 2019
@MatthijsBurgh MatthijsBurgh deleted the update/add-speech-models branch March 9, 2019 14:48
MatthijsBurgh added a commit that referenced this pull request Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants