-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download latest released models #28
Conversation
@MatthijsBurgh I can't wait for tue-robotics/tue-env#377 to be merged before finishing up this system. So I have opened an issue to generalize the path dirs after the merge in tue-env. |
@MatthijsBurgh review please |
@@ -0,0 +1,16 @@ | |||
#! /usr/bin/env bash | |||
|
|||
url=$(curl -s https://api.github.com/repos/tue-robotics/speech_recognition/releases/latest | \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check ros-dashboard target, it uses some python to do this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is pretty much the same. Here I am specifying the version to always be the latest one while there it takes a version as an argument and searches over all the versions.
What do you want me to do? That's an overkill for what I am doing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but it uses json in python is cleaner IMO.
@MatthijsBurgh Change to python for parsing the github releases added as a issue #30 . For now lets merge this unless you feel there is an error somewhere in the script. |
Download latest released models
No description provided.