-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update docs #2194
update docs #2194
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2194 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 20 20
Lines 11254 11254
Branches 2297 2297
=======================================
Hits 10293 10293
Misses 523 523
Partials 438 438
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
I made some suggestions to make it more precise; if you see a good way to have an even more precise (and pedantic?) definition of what exactly the node flags record somewhere, that could still be good. |
Thanks a lot @petrelharp! |
Co-authored-by: Peter Ralph <[email protected]>
33ac934
to
76b1ee1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, happy to merge whenever
Thanks! Looks good. |
Update docs on
additional_nodes
flags and correct type inapi.md
.