Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133433 / 25.04 / New virtualization > Add VNC support #11315

Merged
merged 12 commits into from
Jan 20, 2025

NAS-133433: Add enable vnc checkbox in the instance edit form

9025cb4
Select commit
Loading
Failed to load commit list.
Merged

NAS-133433 / 25.04 / New virtualization > Add VNC support #11315

NAS-133433: Add enable vnc checkbox in the instance edit form
9025cb4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 20, 2025 in 0s

82.84% (-0.01%) compared to 644e2a8, passed because coverage increased by 0% when compared to adjusted base (82.85%)

View this Pull Request on Codecov

82.84% (-0.01%) compared to 644e2a8, passed because coverage increased by 0% when compared to adjusted base (82.85%)

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (644e2a8) to head (9025cb4).
Report is 2 commits behind head on master.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...instance-edit-form/instance-edit-form.component.ts 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11315      +/-   ##
==========================================
- Coverage   82.85%   82.84%   -0.01%     
==========================================
  Files        1660     1660              
  Lines       59395    59414      +19     
  Branches     6236     6241       +5     
==========================================
+ Hits        49209    49223      +14     
- Misses      10186    10191       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.