Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-133433 / 25.04 / New virtualization > Add VNC support #11315

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bvasilenko
Copy link
Contributor

@bvasilenko bvasilenko commented Jan 9, 2025

Testing:

Please see ticket

Downstream

Affects Reasoning
Documentation Newly added fields "VNC Enabled" and "VNC Port" in creation and editing form for items of type VM instance on a new Virtualization page

@bvasilenko bvasilenko requested a review from a team as a code owner January 9, 2025 05:51
@bvasilenko bvasilenko requested review from denysbutenko and removed request for a team January 9, 2025 05:51
@bugclerk
Copy link
Contributor

bugclerk commented Jan 9, 2025

@bugclerk bugclerk changed the title NAS-133433: New virtualization > Add VNC support NAS-133433 / 25.04 / New virtualization > Add VNC support Jan 9, 2025
Copy link
Member

@denysbutenko denysbutenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a VM with VNC enabled and port specified, however no VNC link is displayed or can't see VNC settings while editing.

image
image

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (1db0212) to head (2f6376a).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #11315   +/-   ##
=======================================
  Coverage   82.74%   82.75%           
=======================================
  Files        1654     1654           
  Lines       59133    59146   +13     
  Branches     6217     6219    +2     
=======================================
+ Hits        48932    48948   +16     
+ Misses      10201    10198    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants