NAS-131316 / 25.04 / Rename SMART Test Results Fields

[AlexKarpov98]

Testing:

See ticket comments.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-131316

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.91%. Comparing base (43477fb) to head (2f903eb).
Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10768      +/-   ##
==========================================
+ Coverage   80.63%   80.91%   +0.28%     
==========================================
  Files        1570     1571       +1     
  Lines       51514    52116     +602     
  Branches     5809     5813       +4     
==========================================
+ Hits        41538    42172     +634     
+ Misses       9976     9944      -32     

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RehanY147]

Looks good

[RehanY147]

These changes seem different than what's recommended. William asked the remaining to be 0% if it's completed. The PR changes it to "Completed". Also, the PR is missing the fix on the Error field mentioned in the ticket description.

[AlexKarpov98]

@RehanY147 - I talked with @william-gr

1. So we should keep current implementation.

2. Regarding error field - it's updated now.

please review it once again 😄

[RehanY147]

@AlexKarpov98 Please review this ticket. It is addressed to the same area in the UI. In fact, the same column field. See if it should be handled here as I suspect your code in this PR will need to be changed again.
https://ixsystems.atlassian.net/browse/NAS-131537

[RehanY147]

See above comment

[AlexKarpov98]

Hey @RehanY147
I think we should merge this one and do fixes for this ticket https://ixsystems.atlassian.net/browse/NAS-131537 separately

BTW - once you commented PR, no need to request changes as well, comment is counted as a review as well 😄

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.