NAS-131316 / 25.04 / Rename SMART Test Results Fields (#10768)

truenas · Oct 3, 2024 · fe686fc · fe686fc
1 parent 4dbf9e6
commit fe686fc
Show file tree

Hide file tree

Showing 90 changed files with 103 additions and 11 deletions.
diff --git a/.../modules/disks/components/smart-test-result-list/smart-test-result-list.component.spec.ts b/.../modules/disks/components/smart-test-result-list/smart-test-result-list.component.spec.ts
@@ -26,7 +26,7 @@ describe('SmartTestResultListComponent', () => {
     tests: [{
       num: 1,
       description: 'Background long',
-      status_verbose: 'Completed',
+      status_verbose: null,
       segment_number: null,
       lifetime: 15959,
       lba_of_first_error: null,
@@ -41,7 +41,7 @@ describe('SmartTestResultListComponent', () => {
       lifetime: 15929,
       lba_of_first_error: null,
       status: SmartTestResultStatus.Success,
-      remaining: null,
+      remaining: 50,
     },
     {
       num: 3,
@@ -73,7 +73,7 @@ describe('SmartTestResultListComponent', () => {
       lifetime: 15929,
       lba_of_first_error: null,
       status: SmartTestResultStatus.Success,
-      remaining: null,
+      remaining: 0.5,
     },
     {
       num: 3,
@@ -83,7 +83,7 @@ describe('SmartTestResultListComponent', () => {
       lifetime: 16939,
       lba_of_first_error: null,
       status: SmartTestResultStatus.Success,
-      remaining: null,
+      remaining: 0,
     }],
   }];
 
@@ -114,13 +114,13 @@ describe('SmartTestResultListComponent', () => {
 
   it('should show table rows', async () => {
     const expectedRows = [
-      ['Disk', 'Description', 'Status', 'Remaining', 'Lifetime', 'Error'],
-      ['sda', 'Background long', 'SUCCESS', 'Completed', '15959', 'No errors'],
-      ['sda', 'Background short', 'SUCCESS', 'Completed', '15929', 'No errors'],
+      ['Disk', 'Description', 'Status', 'Remaining', 'Lifetime', 'LBA of First Error'],
+      ['sda', 'Background long', 'SUCCESS', '0%', '15959', 'No errors'],
+      ['sda', 'Background short', 'SUCCESS', '50%', '15929', 'No errors'],
       ['sda', 'Background short', 'SUCCESS', 'Completed', '16939', 'No errors'],
       ['sdb', 'Background long', 'SUCCESS', 'Completed', '15959', 'No errors'],
-      ['sdb', 'Background short', 'SUCCESS', 'Completed', '15929', 'No errors'],
-      ['sdb', 'Background short', 'SUCCESS', 'Completed', '16939', 'No errors'],
+      ['sdb', 'Background short', 'SUCCESS', '0.5%', '15929', 'No errors'],
+      ['sdb', 'Background short', 'SUCCESS', '0%', '16939', 'No errors'],
     ];
 
     const cells = await table.getCellTexts();

diff --git a/...orage/modules/disks/components/smart-test-result-list/smart-test-result-list.component.ts b/...orage/modules/disks/components/smart-test-result-list/smart-test-result-list.component.ts
@@ -52,7 +52,11 @@ export class SmartTestResultListComponent implements OnInit {
       title: this.translate.instant('Remaining'),
       propertyName: 'remaining',
       getValue: (row) => {
-        return row.remaining || row.status_verbose;
+        if (typeof row.remaining === 'number' && row.remaining >= 0) {
+          return `${row.remaining}%`;
+        }
+
+        return row.status_verbose ? this.translate.instant(row.status_verbose) : '0%';
       },
     }),
     textColumn({
@@ -63,7 +67,7 @@ export class SmartTestResultListComponent implements OnInit {
       },
     }),
     textColumn({
-      title: this.translate.instant('Error'),
+      title: this.translate.instant('LBA of First Error'),
       propertyName: 'lba_of_first_error',
       getValue: (row) => {
         return row.lba_of_first_error || this.translate.instant('No errors');

diff --git a/src/assets/i18n/af.json b/src/assets/i18n/af.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/ar.json b/src/assets/i18n/ar.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/ast.json b/src/assets/i18n/ast.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/az.json b/src/assets/i18n/az.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/be.json b/src/assets/i18n/be.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/bg.json b/src/assets/i18n/bg.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/bn.json b/src/assets/i18n/bn.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/br.json b/src/assets/i18n/br.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/bs.json b/src/assets/i18n/bs.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/ca.json b/src/assets/i18n/ca.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/cs.json b/src/assets/i18n/cs.json
@@ -1823,6 +1823,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/cy.json b/src/assets/i18n/cy.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/da.json b/src/assets/i18n/da.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/de.json b/src/assets/i18n/de.json
@@ -1635,6 +1635,7 @@
   "Keys for {id} datasets": "",
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",
   "LDAP Realm": "",

diff --git a/src/assets/i18n/dsb.json b/src/assets/i18n/dsb.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/el.json b/src/assets/i18n/el.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/en-au.json b/src/assets/i18n/en-au.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/en-gb.json b/src/assets/i18n/en-gb.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/en.json b/src/assets/i18n/en.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/eo.json b/src/assets/i18n/eo.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/es-ar.json b/src/assets/i18n/es-ar.json
@@ -1196,6 +1196,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP Domain": "",
   "LDAP Realm": "",

diff --git a/src/assets/i18n/es-co.json b/src/assets/i18n/es-co.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/es-mx.json b/src/assets/i18n/es-mx.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/es-ni.json b/src/assets/i18n/es-ni.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/es-ve.json b/src/assets/i18n/es-ve.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/es.json b/src/assets/i18n/es.json
@@ -2133,6 +2133,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/et.json b/src/assets/i18n/et.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/eu.json b/src/assets/i18n/eu.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/fa.json b/src/assets/i18n/fa.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/fi.json b/src/assets/i18n/fi.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/fr.json b/src/assets/i18n/fr.json
@@ -336,6 +336,7 @@
   "Keychain Credential Write": "",
   "Keypairs": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP Domain": "",
   "LDAP Realm": "",
   "LDAP Server": "",

diff --git a/src/assets/i18n/fy.json b/src/assets/i18n/fy.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/ga.json b/src/assets/i18n/ga.json
@@ -47,6 +47,7 @@
   "Incoming / Outgoing network traffic": "",
   "Install NVIDIA Drivers": "",
   "Install via YAML": "",
+  "LBA of First Error": "",
   "Languages other than <i>English</i> are provided by      the community and may be incomplete.      <a href=\"https://github.com/truenas/webui/blob/master/TRANSLATING.md\" target=\"_blank\">Learn how to contribute.</a>": "",
   "Latest version": "",
   "Legacy OS: Extent block size 512b, TPC enabled, no Xen compat mode, SSD speed": "",

diff --git a/src/assets/i18n/gd.json b/src/assets/i18n/gd.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/gl.json b/src/assets/i18n/gl.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/he.json b/src/assets/i18n/he.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/hi.json b/src/assets/i18n/hi.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/hr.json b/src/assets/i18n/hr.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/hsb.json b/src/assets/i18n/hsb.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",

diff --git a/src/assets/i18n/hu.json b/src/assets/i18n/hu.json
@@ -2334,6 +2334,7 @@
   "Keys pending to be synced between KMIP server and TN database were cleared.": "",
   "Keywords": "",
   "LACPDU Rate": "",
+  "LBA of First Error": "",
   "LDAP": "",
   "LDAP - Primary Domain": "",
   "LDAP Domain": "",