Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130874 / 25.04 / snapshot batch delete button is deleting ALL snapshots, not just selected #10602

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

AlexKarpov98
Copy link
Contributor

Testing: see ticket

Result: ⬇️

Screen.Recording.2024-09-02.at.12.21.47.mov

@AlexKarpov98 AlexKarpov98 self-assigned this Sep 2, 2024
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 2, 2024 09:24
@AlexKarpov98 AlexKarpov98 requested review from bvasilenko and removed request for a team September 2, 2024 09:24
@bugclerk
Copy link
Contributor

bugclerk commented Sep 2, 2024

@bugclerk bugclerk changed the title NAS-130874: snapshot batch delete button is deleting ALL snapshots, not just selected NAS-130874 / 25.04 / snapshot batch delete button is deleting ALL snapshots, not just selected Sep 2, 2024
Copy link

codecov bot commented Sep 2, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes missing coverage. Please review.

Project coverage is 79.73%. Comparing base (f58a257) to head (2f8b5eb).

Files with missing lines Patch % Lines
...docker-images-list/docker-images-list.component.ts 16.66% 5 Missing ⚠️
...snapshots/snapshot-list/snapshot-list.component.ts 0.00% 5 Missing ⚠️
.../disks/components/disk-list/disk-list.component.ts 16.66% 5 Missing ⚠️
...tem/bootenv/bootenv-list/bootenv-list.component.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10602      +/-   ##
==========================================
- Coverage   79.75%   79.73%   -0.02%     
==========================================
  Files        1561     1561              
  Lines       51259    51267       +8     
  Branches     5829     5829              
==========================================
  Hits        40880    40880              
- Misses      10379    10387       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@bugclerk
Copy link
Contributor

bugclerk commented Sep 5, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants