Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130874 / 24.10-RC.1 / snapshot batch delete button is deleting ALL snapshots, not just selected (by AlexKarpov98) #10622

Merged
merged 2 commits into from
Sep 9, 2024
Merged

NAS-130874 / 24.10-RC.1 / snapshot batch delete button is deleting ALL snapshots, not just selected (by AlexKarpov98) #10622

merged 2 commits into from
Sep 9, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Sep 5, 2024

Automatic cherry-pick failed. Please resolve conflicts by running:

git reset --hard HEAD~1
git cherry-pick -x 8dc700154fd519606a4f610976addadc0f5bf412
git cherry-pick -x 01f0d26154948add56903fefe05c79f3a0c47a20
git cherry-pick -x 2f8b5eb885246f4ed1f5a55a71dabf6892d9642c

If the original PR was merged via a squash, you can just cherry-pick the squashed commit:

git reset --hard HEAD~1
git cherry-pick -x f9268d054b24b8f6edfbcacaf0fa35395b5a2b29

Testing: see ticket

Result: ⬇️

Screen.Recording.2024-09-02.at.12.21.47.mov

Original PR: #10602
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130874

@AlexKarpov98
NAS-130874 / 25.04 / snapshot batch delete button is deleting ALL sna…
d510dc9 
…pshots, not just selected (#10602)

* NAS-130874: snapshot batch delete button is deleting ALL snapshots, not just selected

* NAS-130874: snapshot batch delete button is deleting ALL snapshots, not just selected

(cherry picked from commit f9268d0)
AlexKarpov98
AlexKarpov98 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@AlexKarpov98 AlexKarpov98 marked this pull request as ready for review September 9, 2024 12:11
@AlexKarpov98 AlexKarpov98 requested a review from a team as a code owner September 9, 2024 12:11
@AlexKarpov98 AlexKarpov98 requested review from undsoft and removed request for a team September 9, 2024 12:11
@AlexKarpov98 AlexKarpov98 enabled auto-merge (squash) September 9, 2024 12:11
@AlexKarpov98 AlexKarpov98 merged commit 18b5597 into stable/electriceel Sep 9, 2024
5 checks passed
@AlexKarpov98 AlexKarpov98 deleted the NAS-130874-24.10-RC.1 branch September 9, 2024 12:43
@bugclerk
Copy link
Contributor Author

bugclerk commented Sep 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexKarpov98 AlexKarpov98 AlexKarpov98 approved these changes

@undsoft undsoft Awaiting requested review from undsoft undsoft is a code owner automatically assigned from truenas/ui-team

Assignees

@AlexKarpov98 AlexKarpov98

Labels
no-time-tracked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bugclerk @AlexKarpov98