Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130739 / 24.10-RC.1 / Remove references to Pods in apps #10516

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Aug 21, 2024

Changes:

Changes strings and renames some things in code.

Testing:

Code review.

Downstream

Affects Reasoning
Documentation Renames some strings that should have been renamed already.

@undsoft undsoft added the backport-25.04-RC.1 Fangtooth RC1 label Aug 21, 2024
@undsoft undsoft requested a review from a team as a code owner August 21, 2024 10:24
@undsoft undsoft requested review from RehanY147 and removed request for a team August 21, 2024 10:24
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-130739: Remove references to Pods in apps NAS-130739 / 24.10-RC.1 / Remove references to Pods in apps Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (stable/electriceel@2da42ab). Learn more about missing BASE report.

Files Patch % Lines
...l-details-dialog/shell-details-dialog.component.ts 25.00% 3 Missing ⚠️
...ed-apps/container-logs/container-logs.component.ts 87.50% 2 Missing ⚠️
...-apps/container-shell/container-shell.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             stable/electriceel   #10516   +/-   ##
=====================================================
  Coverage                      ?   79.59%           
=====================================================
  Files                         ?     1564           
  Lines                         ?    51073           
  Branches                      ?     5886           
=====================================================
  Hits                          ?    40650           
  Misses                        ?    10423           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit af046c5 into stable/electriceel Aug 21, 2024
9 checks passed
@undsoft undsoft deleted the NAS-130739 branch August 21, 2024 11:27
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants