Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130739 / 25.04 / Remove references to Pods in apps (by undsoft) #10518

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

bugclerk
Copy link
Contributor

Changes:

Changes strings and renames some things in code.

Testing:

Code review.

Downstream

Affects Reasoning
Documentation Renames some strings that should have been renamed already.

Original PR: #10516
Jira URL: https://ixsystems.atlassian.net/browse/NAS-130739

@bugclerk bugclerk requested a review from a team as a code owner August 21, 2024 11:27
@bugclerk bugclerk requested review from denysbutenko and removed request for a team August 21, 2024 11:27
Copy link
Collaborator

@undsoft undsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported

@undsoft undsoft enabled auto-merge (squash) August 21, 2024 11:29
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Project coverage is 79.54%. Comparing base (ce029e7) to head (3cedba6).
Report is 1 commits behind head on master.

Files Patch % Lines
...l-details-dialog/shell-details-dialog.component.ts 25.00% 3 Missing ⚠️
...ed-apps/container-logs/container-logs.component.ts 87.50% 2 Missing ⚠️
...-apps/container-shell/container-shell.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10518   +/-   ##
=======================================
  Coverage   79.54%   79.54%           
=======================================
  Files        1560     1560           
  Lines       50781    50781           
  Branches     5815     5815           
=======================================
  Hits        40396    40396           
  Misses      10385    10385           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AlexKarpov98 AlexKarpov98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ported.

@undsoft undsoft disabled auto-merge August 21, 2024 14:21
@undsoft undsoft merged commit 1dba695 into master Aug 21, 2024
8 of 9 checks passed
@undsoft undsoft deleted the NAS-130739-25.04 branch August 21, 2024 14:21
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Aug 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants