Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129964 / 24.10 / Remove host id from bug reports #10302

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

undsoft
Copy link
Collaborator

@undsoft undsoft commented Jul 9, 2024

You can use mocks to test what message is being sent to the server, but changes are pretty self-explanatory.

@undsoft undsoft requested a review from a team as a code owner July 9, 2024 12:05
@undsoft undsoft requested review from denysbutenko and removed request for a team July 9, 2024 12:05
@bugclerk
Copy link
Contributor

bugclerk commented Jul 9, 2024

@bugclerk bugclerk changed the title NAS-129964: Remove host id from bug reports NAS-129964 / 24.10 / Remove host id from bug reports Jul 9, 2024
@undsoft undsoft enabled auto-merge (squash) July 9, 2024 12:14
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.58%. Comparing base (46677f8) to head (8087d35).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10302      +/-   ##
==========================================
- Coverage   76.58%   76.58%   -0.01%     
==========================================
  Files        1587     1587              
  Lines       54734    54731       -3     
  Branches     6471     6471              
==========================================
- Hits        41916    41913       -3     
  Misses      12818    12818              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@undsoft undsoft merged commit 2a8d54e into master Jul 9, 2024
10 checks passed
@undsoft undsoft deleted the NAS-129964 branch July 9, 2024 12:39
@bugclerk
Copy link
Contributor

bugclerk commented Jul 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants