Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-129964 / 24.04.3 / Remove host id from bug reports (by undsoft) #10303

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Jul 9, 2024

You can use mocks to test what message is being sent to the server, but changes are pretty self-explanatory.

Original PR: #10302
Jira URL: https://ixsystems.atlassian.net/browse/NAS-129964

@bugclerk bugclerk requested a review from a team as a code owner July 9, 2024 12:39
@bugclerk bugclerk requested review from bvasilenko and removed request for a team July 9, 2024 12:39
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (stable/dragonfish@9face36). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             stable/dragonfish   #10303   +/-   ##
====================================================
  Coverage                     ?   66.04%           
====================================================
  Files                        ?     1428           
  Lines                        ?    54700           
  Branches                     ?     6582           
====================================================
  Hits                         ?    36124           
  Misses                       ?    18576           
  Partials                     ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@bvasilenko bvasilenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport

@undsoft undsoft merged commit 412300f into stable/dragonfish Jul 10, 2024
10 checks passed
@undsoft undsoft deleted the NAS-129964-24.04.3 branch July 10, 2024 09:18
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Jul 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants