Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131293 / 25.04 / fix regression in alerts #14539

Merged
merged 1 commit into from
Sep 18, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/middlewared/middlewared/plugins/alert.py
Original file line number Diff line number Diff line change
Expand Up @@ -712,14 +712,14 @@ async def __run_other_node_alert_source(self, name):
try:
try:
for alert in await self.middleware.call("failover.call_remote", "alert.run_source", [name]):
other_node_alerts.append([
other_node_alerts.append(
Alert(**dict(
{k: v for k, v in alert.items() if k in keys},
klass=AlertClass.class_by_name[alert["klass"]],
_source=alert["source"],
_key=alert["key"]
))
])
)
except CallError as e:
if e.errno not in NETWORK_ERRORS + (CallError.EALERTCHECKERUNAVAILABLE,):
raise
Expand Down
Loading