Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131293 / 25.04 / fix regression in alerts #14539

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

yocalebo
Copy link
Contributor

A subtle typo is causing this crash on HA. It's happening because I'm appending a list to a list.

[2024/09/18 10:25:58] (ERROR) middlewared.job.run():504 - Job <bound method AlertService.process_alerts of <middlewared.plugins.alert.AlertService object at 0x7f2ac1ecd7d0>> failed
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/middlewared/job.py", line 489, in run
    await self.future
  File "/usr/lib/python3/dist-packages/middlewared/job.py", line 534, in __run_body
    rv = await self.method(*args)
         ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/middlewared/plugins/alert.py", line 494, in process_alerts
    await self.__run_alerts()
  File "/usr/lib/python3/dist-packages/middlewared/plugins/alert.py", line 774, in __run_alerts
    oalert.node = fi.other_node
    ^^^^^^^^^^^
AttributeError: 'list' object has no attribute 'node'

@yocalebo yocalebo requested a review from a team September 18, 2024 23:35
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title fix regression in alerts NAS-131293 / 25.04 / fix regression in alerts Sep 18, 2024
@truenas truenas deleted a comment from bugclerk Sep 18, 2024
@yocalebo yocalebo merged commit c433eea into master Sep 18, 2024
2 of 3 checks passed
@yocalebo yocalebo deleted the fix-alert-regress branch September 18, 2024 23:38
@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants