Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMD] Default to stream-pipeline-v2 #4665

Merged
merged 3 commits into from
Sep 26, 2024

Conversation

sjw36
Copy link
Contributor

@sjw36 sjw36 commented Sep 6, 2024

No description provided.

@sjw36 sjw36 force-pushed the sjw/remove-old-pipeliner branch 2 times, most recently from d8699df to 675fa43 Compare September 16, 2024 19:39
@binarman
Copy link
Contributor

I've looked into LDS overflow issue in this PR: pipeline allocates memory for gemm operands like this:

%47 = triton_gpu.local_alloc  : () -> !tt.memdesc<2x128x128xf8E5M2, #shared, #triton_gpu.shared_memory, mutable>
%48 = triton_gpu.local_alloc  : () -> !tt.memdesc<2x128x256xf8E5M2, #shared1, #triton_gpu.shared_memory, mutable>

First allocation takes 2x128x128=32 kBytes
Second allocation takes 2x128x256=64 kBytes

This happens because num_pipeline_stages kernel argument equal 3 by default.

I think we can simply reduce this value to 2 for AMD, LDS is sufficient in this case.

Copy link
Collaborator

@antiagainst antiagainst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But blocking for now before figuring out some final perf regressions

@antiagainst antiagainst enabled auto-merge (squash) September 26, 2024 15:22
@antiagainst antiagainst merged commit a70d585 into triton-lang:main Sep 26, 2024
7 checks passed
@antiagainst antiagainst deleted the sjw/remove-old-pipeliner branch September 26, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants