-
-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T3T1 in Suite and Connect #11968
T3T1 in Suite and Connect #11968
Conversation
cc @Hannsek t3t1 should more or less work in suite (develop) even without these changes here. |
I am quite surprised how many changes were needed to satisfy the type-check in suite and native. We don't have t3t1 images, it would be nice to get some dummy images. So far I have only put todo comments and model T images there. |
Model T images are quite dangerous. We need to make sure we will replace them with proper ones. |
I've created simple t3t1 placeholder image which should be easily recognizable from other devices. I'm tracking the progress of adding new renders/animations in #11841 and https://www.notion.so/satoshilabs/Trezor-graphic-redesign-tasks-ac5ac14135c3430b9c3520371e463025?pvs=4 |
372dfe1
to
2c709bf
Compare
97e51d4
to
f1b1787
Compare
f98bda0
to
2b198f3
Compare
497c233
to
2687b50
Compare
2687b50
to
e238451
Compare
steps={5} | ||
activeStep={5} | ||
onCancel={() => {}} | ||
deviceModelInternal={DeviceModelInternal.T2T1} | ||
deviceModelInternal={DeviceModelInternal.T3T1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets keep T2T1 and use T3T1 as separate line
@@ -32,6 +32,7 @@ export const CoinSupport = Type.Object({ | |||
T1B1: Type.Union([Type.String(), Type.Literal(false)]), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract to:
const xxx: Record<DeviceEnum, Type.?????> = {
T1B1: Type.Union([Type.String(), Type.Literal(false)]),
T2T1: Type.Union([Type.String(), Type.Literal(false)]),
T2B1: Type.Union([Type.String(), Type.Literal(false)]),
T3T1: Type.Union([Type.String(), Type.Literal(false)]),
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The whole thing could be refactored to
export const CoinSupport = Type.Composite([
Type.Object({
connect: Type.Boolean(),
}),
Type.Record(
Type.KeyOfEnum(DeviceModelInternal),
Type.Union([Type.String(), Type.Literal(false)]),
),
]);
which resolves to
type CoinSupport = {
connect: boolean;
T1B1: string | false;
T2T1: string | false;
T2B1: string | false;
T3T1: string | false;
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just types and small stuff, can be solved in other PR to avoid conflicts
Added support for T3T1
T2B1
, you have to turn it off in settings