Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): connect tests with T3T1 #12010

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Conversation

karliatto
Copy link
Member

@karliatto karliatto commented Apr 15, 2024

This depends of #11968

Description

Adding new device to nightly other devices tests T3T1 to connect unit tests in CI GitHub Action.

The other devices tests is running only on schedule but I run it on this job in order to prove it works https://github.com/trezor/trezor-suite/actions/runs/8684091754/job/23811119867?pr=12010

I also added descriptions to make tests more clear:

image

@karliatto karliatto force-pushed the test/T3T1-connect-tests branch 4 times, most recently from b2ef9f9 to ca167a9 Compare April 15, 2024 06:19
@karliatto karliatto changed the title wip ci(github): connect tests with T3T1 Apr 15, 2024
@karliatto karliatto marked this pull request as ready for review April 15, 2024 06:22
@mroz22
Copy link
Contributor

mroz22 commented Apr 15, 2024

cool, we only need to wait for #11968
or maybe removing commit afb6181 could also help. this commit forces you to add a lot of code on higher layers.

@mroz22
Copy link
Contributor

mroz22 commented Apr 19, 2024

#11968 has been merged now, so I guess you can rebase and merge it.

@karliatto karliatto merged commit 6371d10 into develop Apr 19, 2024
49 checks passed
@karliatto karliatto deleted the test/T3T1-connect-tests branch April 19, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants