Add StorageID to Repo endpoints #8506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itaigilo
added
exclude-changelog
E2E Test Results - DynamoDB Local - Local Block Adapter |
E2E Test Results - Quickstart |
…e-id-to-repo-endpoints
…e-id-to-repo-endpoints
guy-har
reviewed
Jan 16, 2025
pkg/api/controller.go
Outdated
| @@ -2055,6 +2059,7 @@ func (c *Controller) CreateRepository(w http.ResponseWriter, r *http.Request, bo | |||
| CreationDate: newRepo.CreationDate.Unix(), | |||
| DefaultBranch: newRepo.DefaultBranch, | |||
| Id: newRepo.Name, | |||
| StorageId: swag.String(newRepo.StorageNamespace), | |||
There was a problem hiding this comment.
Good catch! 🙈
Fixed.
N-o-Z
requested changes
Jan 17, 2025
…e-id-to-repo-endpoints
There are no such tests covering StorageNamespace in the controller tests, so I don't think we should add ones for StorageID. It's covered by Esti - let's added it when we get there. |
…e-id-to-repo-endpoints
|
@N-o-Z can you please re-review? |
N-o-Z
approved these changes
Jan 17, 2025
itaigilo
added a commit
that referenced
this pull request
Jan 18, 2025
* Add StorageID to Repository entity * Bug fixes * Remove API changes * Almost empty commit * Revert almso empty commit * Remove from API * Fix PR comments * Fix tests * Update tests * Allow only empty StorageID * Revert "Allow only empty StorageID" This reverts commit 298bc0d. * Revert "Revert "Allow only empty StorageID"" This reverts commit 299c292. * Change validation * Remove StorageID in a test * Add StorageID to Repo endpoints (#8506) * Add StorageID to Repo endpoints * Add param to Creation * Add basic unit-tests * Fix param * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.