Skip to content

Commit

Permalink
Add StorageID to Repository entity (#8502)
Browse files Browse the repository at this point in the history
* Add StorageID to Repository entity

* Bug fixes

* Remove API changes

* Almost empty commit

* Revert almso empty commit

* Remove from API

* Fix PR comments

* Fix tests

* Update tests

* Allow only empty StorageID

* Revert "Allow only empty StorageID"

This reverts commit 298bc0d.

* Revert "Revert "Allow only empty StorageID""

This reverts commit 299c292.

* Change validation

* Remove StorageID in a test

* Add StorageID to Repo endpoints (#8506)

* Add StorageID to Repo endpoints

* Add param to Creation

* Add basic unit-tests

* Fix param

* Update tests
  • Loading branch information
itaigilo authored Jan 18, 2025
1 parent 14afd5d commit bca4801
Show file tree
Hide file tree
Showing 33 changed files with 493 additions and 306 deletions.
6 changes: 6 additions & 0 deletions api/swagger.yml
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,9 @@ components:
description: Unix Epoch in seconds
default_branch:
type: string
storage_id:
type: string
description: Unique identifier of the underlying data store
storage_namespace:
type: string
description: Filesystem URI to store the underlying data in (e.g. "s3://my-bucket/some/path/")
Expand Down Expand Up @@ -264,6 +267,9 @@ components:
name:
type: string
pattern: "^[a-z0-9][a-z0-9-]{2,62}$"
storage_id:
type: string
description: Unique identifier of the underlying data store
storage_namespace:
type: string
description: 'Filesystem URI to store the underlying data in (e.g. "s3://my-bucket/some/path/")'
Expand Down
10 changes: 10 additions & 0 deletions clients/java/api/openapi.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions clients/java/docs/Repository.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions clients/java/docs/RepositoryCreation.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions clients/python/docs/Repository.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions clients/python/docs/RepositoryCreation.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion clients/python/lakefs_sdk/models/repository.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion clients/python/lakefs_sdk/models/repository_creation.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions clients/python/test/test_repository.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions clients/python/test/test_repository_creation.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions clients/python/test/test_repository_list.py

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions clients/rust/docs/Repository.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions clients/rust/docs/RepositoryCreation.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit bca4801

Please sign in to comment.