Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Torch an optional dependency #95

Merged
merged 7 commits into from
Mar 7, 2024
Merged

Make Torch an optional dependency #95

merged 7 commits into from
Mar 7, 2024

Conversation

suhacker1
Copy link
Collaborator

@suhacker1 suhacker1 commented Mar 1, 2024

This PR makes PyTorch an optional dependency. It also updates the PyTorch file formats list both to clarify it and fix a typo.

@suhacker1 suhacker1 marked this pull request as ready for review March 1, 2024 17:31
@suhacker1 suhacker1 requested review from Boyan-MILANOV and removed request for ESultanik March 1, 2024 17:31
@suhacker1
Copy link
Collaborator Author

Since PyTorch is now an optional dependency, we should update the installation instructions in the README when the new version is out.

@suhacker1 suhacker1 requested a review from ESultanik March 1, 2024 17:43
fickling/pytorch.py Outdated Show resolved Hide resolved
README.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per your comment in the PR discussions, I think you should update the README with the new install instructions in this PR already. They go together.

If we don't want to have this pushed to master before a new release is out then it's perhaps time to have a dev working branch and use master only for releases. In fact I think we should do it anyway if we keep developing new fickling features

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. I'll add this and merge this PR right before making a new release then to make this easier in this case. But we can discuss the dev branch later.

Copy link
Collaborator

@Boyan-MILANOV Boyan-MILANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@suhacker1 suhacker1 linked an issue Mar 7, 2024 that may be closed by this pull request
@suhacker1 suhacker1 merged commit 4233c3a into master Mar 7, 2024
11 checks passed
@suhacker1 suhacker1 deleted the sh/opt branch March 7, 2024 17:03
@drdavella
Copy link

Hi! We appreciate the work you're doing and especially this change to make Torch and optional dependency. I was just curious whether there are any plans to release this change in the near future? Thank you!

@suhacker1
Copy link
Collaborator Author

Thanks for the reminder! We'll put out the new release very soon.

@suhacker1
Copy link
Collaborator Author

@drdavella We published the new release! Please don't hesitate to reach out with any issues or feature requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch dependency
3 participants