-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Torch an optional dependency #95
Conversation
Since PyTorch is now an optional dependency, we should update the installation instructions in the README when the new version is out. |
README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per your comment in the PR discussions, I think you should update the README with the new install instructions in this PR already. They go together.
If we don't want to have this pushed to master
before a new release is out then it's perhaps time to have a dev
working branch and use master
only for releases. In fact I think we should do it anyway if we keep developing new fickling
features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense. I'll add this and merge this PR right before making a new release then to make this easier in this case. But we can discuss the dev
branch later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi! We appreciate the work you're doing and especially this change to make Torch and optional dependency. I was just curious whether there are any plans to release this change in the near future? Thank you! |
Thanks for the reminder! We'll put out the new release very soon. |
@drdavella We published the new release! Please don't hesitate to reach out with any issues or feature requests! |
This PR makes PyTorch an optional dependency. It also updates the PyTorch file formats list both to clarify it and fix a typo.