Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch dependency #92

Closed
stevemarin opened this issue Feb 6, 2024 · 3 comments · Fixed by #95
Closed

torch dependency #92

stevemarin opened this issue Feb 6, 2024 · 3 comments · Fixed by #95

Comments

@stevemarin
Copy link

Hello and thank you very much for all your hard work! We use fickling as a dependency of polyfile. Version 0.1.0 added a significant build time for us due to the inclusion of torch as a requirement.

We can continue working with 0.0.8 for now, so we have no complaints. But we were wondering if the torch requirement could be made optional in the future?

Thank you again!

@suhacker1
Copy link
Collaborator

Thanks for raising this issue! We're looking into this for the next release.

@drdavella
Copy link

Hi! I just want to second this issue. I think this is a really cool project and I would love to recommend fickling to our users as a way to harden pickle usage when handling potentially untrusted data.

However I'm not sure how many users would be okay with adding torch as a transient dependency so I agree it would be great if it were optional.

@suhacker1 suhacker1 linked a pull request Mar 7, 2024 that will close this issue
@drdavella
Copy link

Thanks for the quick turnaround and response! I'll keep an eye out for the release.

Just in case you're curious: our framework automatically introduces fickling to code that is using pickle and helps harden against cases where untrusted pickles may be loaded: pixee/codemodder-python#332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants