Gd/convert sdk to kotlin/159978777 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumedebavelaere
force-pushed
the
gd/convert_sdk_to_kotlin/159978777
branch
10 times, most recently
from
47cac37 to
9c2b8db
Compare
guillaumedebavelaere
force-pushed
the
gd/convert_sdk_to_kotlin/159978777
branch
from
9c2b8db to
90b81f2
Compare
guillaumedebavelaere
changed the title
guillaumedebavelaere
force-pushed
the
gd/convert_sdk_to_kotlin/159978777
branch
2 times, most recently
from
0eadf6b to
433cfec
Compare
guillaumedebavelaere
force-pushed
the
gd/convert_sdk_to_kotlin/159978777
branch
from
433cfec to
7c1d816
Compare
Merged
gigiyy
reviewed
Sep 3, 2018
| /** | ||
| * [Testing Fundamentals](http://d.android.com/tools/testing/testing_android.html) | ||
| */ | ||
| class ApplicationTest : ApplicationTestCase<Application>(Application::class.java) |
There was a problem hiding this comment.
this ApplicationTest is not used, should be removed too.
There was a problem hiding this comment.
Removed
gigiyy
reviewed
Sep 3, 2018
|
|
||
| @RunWith(AndroidJUnit4::class) | ||
| @LargeTest | ||
| class TradeItLinkedBrokerManagerTest { |
There was a problem hiding this comment.
running androidTests on emulator with api level 19 got below error:
Test running failed: Instrumentation run failed due to 'java.lang.ClassNotFoundException'
do you have any idea what went wrong? tests was ok in api level 22 and 28 emulators though.
There was a problem hiding this comment.
Not sure. I tested on develop and the error was already there
gigiyy
reviewed
Sep 3, 2018
|
|
||
| val context = context | ||
| val apiKey = apiKey | ||
| val environment = environment |
There was a problem hiding this comment.
you can just declare the property in the constructor directly instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.