Gz/convert to kotlin #100

gigiyy · 2018-08-14T05:55:28Z

example App conversion to kotlin

convert the source code to kotlin using IDE own tool
bounced the SDK version, gradle version, android plugin version and espresso test versions.
using class name to look for the text fields with UiSelector in MainActivity test.

guillaumedebavelaere · 2018-08-23T07:50:20Z

Can we keep the java exampleApp and move the Kotlin code in a separate example app target?
Are the tests ok?
Did you test with old versions of Android in the emulator?

oliver-was-here · 2018-08-23T21:37:26Z

@gigiyy I'll take a look at this tomorrow, my brain has had too much PR for one day 😬

oliver-was-here · 2018-08-24T15:10:14Z

seems odd to me that all the source is nested under main/java, is it possible to move these .kt files to main/kotlin?

guillaumedebavelaere

With the changes of the android target/compile versions, have you tested with different versions in the emulator? The ideal would be to test with the min and max version.
The tests are not passing for me (version 23 in the emulator) for the java version, and for the Kotlin version I am not able to launch anything, it says to select a SDK version:

guillaumedebavelaere · 2018-08-30T07:46:09Z

exampleApp/src/main/java/it/trade/android/exampleapp/LinkedBrokerAccountsActivity.kt

+    override fun onCreate(savedInstanceState: Bundle?) {
+        super.onCreate(savedInstanceState)
+        setContentView(R.layout.activity_linked_broker_accounts)
+        val textView = linked_broker_accounts_textview //this.findViewById(R.id.linked_broker_accounts_textview) as TextView?


Can we delete this comment?

guillaumedebavelaere · 2018-08-30T07:50:53Z

exampleApp/src/androidTest/java/it/trade/android/exampleapp/ApplicationTest.kt

+/**
+ * [Testing Fundamentals](http://d.android.com/tools/testing/testing_android.html)
+ */
+class ApplicationTest : ApplicationTestCase<Application>(Application::class.java)


If possible, can we delete this, as it does nothing special?

deleted. it seems the left over of the skeleton when application is created.

guillaumedebavelaere · 2018-08-30T07:53:29Z

exampleApp/src/test/java/it/trade/android/exampleapp/ExampleUnitTest.kt

+/**
+ * To work on unit tests, switch the Test Artifact in the Build Variants view.
+ */
+class ExampleUnitTest {


Can we remove this, as it does nothing special?

deleted. this folder was supposed to contain those tests that don't need to use espresso test framework.

guillaumedebavelaere · 2018-08-30T08:05:02Z

exampleAppKotlin/build.gradle

+    implementation 'com.android.support:customtabs:27.1.1'
+    implementation 'com.android.support:appcompat-v7:27.1.1'
+    implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
+    implementation "org.jetbrains.anko:anko:$anko_version"


What is this library for?

https://github.com/Kotlin/anko, I'm planning the use this library when further improvement to the app is done. it can be safely removed though if not needed.

Ok, if currently there are nothing using it, can you remove it?

guillaumedebavelaere · 2018-08-30T08:08:11Z

...rc/main/java/it/trade/android/sdk/model/TradeItPreviewStockOrEtfOrderResponseParcelable.java

-                "orderId='" + orderId + '\'' +
-                ", orderDetails=" + orderDetails +
+                "orderId='" + orderId + "'" +
+                ", ackWarningsList=[]" +


These are empty arrays?

regenerate using the IDE instead.

guillaumedebavelaere · 2018-08-30T08:11:14Z

tradeit-android-sdk/src/main/java/it/trade/android/sdk/model/TradeItOrderDetailsParcelable.java

@@ -34,6 +34,42 @@
    TradeItOrderDetailsParcelable() {
    }

+    @Override
+    public String toString() {


Is there a real benefit in term of performance, writing a custom toString() with StringBuilder than generating the method by IntelliJ?

I just didn't realize it can be generated. 😱

guillaumedebavelaere · 2018-08-30T08:19:24Z

exampleApp/src/main/java/it/trade/android/exampleapp/MainActivity.java

@@ -68,8 +68,8 @@
        DELETE_ALL_LINKED_BROKERS("Delete all linked brokers"),
        AUTHENTICATE_FIRST_LINKED_BROKER("Authenticate first linked broker"),
        AUTHENTICATE_ALL_LINKED_BROKERS("Authenticate all linked brokers"),
-        AUTHENTICATE_WITH_SECURITY_QUESTION_SIMPLE("Simple security question"),
-        AUTHENTICATE_WITH_SECURITY_QUESTION_OPTIONS("Security question with options"),
+//        AUTHENTICATE_WITH_SECURITY_QUESTION_SIMPLE("Simple security question"),


Why are we removing these?

originally it's not implemented, not used at all. in fact, to test security questions, we just need to use same testOAuthFlow and use dummySecurity and dummyOption instead.

Ok, can we remove them if we are not using instead of commenting out?

gigiyy · 2018-08-30T11:37:42Z

HI @guillaumedebavelaere, you will need to install chrome browser in your emulator( I tested in api level22, android 5.1) and it works ok. you can download the apk from apkmirror.com inside the emulator itself. the reason is that, current test only works with chrome custom tab, and not working with webview for oAuth pages (will need to use espresso-web instead)

guillaumedebavelaere · 2018-08-30T13:37:58Z

I installed chrome, but the tests are not passing (API 19). It is blocked when entering the credentials in the oAuth flow.

android.support.test.uiautomator.UiObjectNotFoundException: UiSelector[RESOURCE_ID=loginUser]

gigiyy · 2018-08-30T13:44:38Z

can you try run uiautomatorviewer when the oAuth page is shown and check whether it's a webview or a chrome tab? you should be able to inspect the text field if it's a custom tab.

guillaumedebavelaere · 2018-08-31T05:28:10Z

working now 👍

guillaumedebavelaere · 2018-08-31T05:51:04Z

Let's wait to review and merge this one before: #102

gigiyy force-pushed the gz/convert_to_kotlin branch from 70fc2c4 to 85bd7eb Compare August 16, 2018 14:21

falnatsheh requested review from oliver-was-here, falnatsheh and mitochondrion August 23, 2018 17:54

gigiyy requested a review from guillaumedebavelaere August 29, 2018 14:02

guillaumedebavelaere reviewed Aug 30, 2018

View reviewed changes

gigiyy force-pushed the gz/convert_to_kotlin branch from 7b268ba to d17f84f Compare August 30, 2018 15:40

gigiyy and others added 15 commits September 3, 2018 10:40

convert to kotlin ph1

8134e54

convert to kotlin ph2

2426e75

bounced the espresso and build tool versions

7d63ac9

preserver the original java example app

e2ce347

change source root to kotlin

39e3b3b

adjust the waiting time for tests

56bb435

fix java test case too

16ef836

add anko dependency

eac096f

add order detail parcelable toString()

89c7746

all tests cases passed

efbc4c8

remove unused menu items

6ee41a3

remove used code

4754891

use the IDE to generate the toString method instead

ee50221

use className selector instead(to make test work in android 19)

47927eb

Fix rebase conflicts and issues

e9b75f0

guillaumedebavelaere force-pushed the gz/convert_to_kotlin branch from d17f84f to e9b75f0 Compare September 3, 2018 08:57

add toString() method back to TradeItOrderDetailsParcelable

60453be

guillaumedebavelaere merged commit ef6b642 into develop Sep 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gz/convert to kotlin #100

Gz/convert to kotlin #100

gigiyy commented Aug 14, 2018

guillaumedebavelaere commented Aug 23, 2018

oliver-was-here commented Aug 23, 2018

oliver-was-here commented Aug 24, 2018

guillaumedebavelaere left a comment

guillaumedebavelaere Aug 30, 2018

gigiyy Aug 30, 2018

guillaumedebavelaere Aug 30, 2018

gigiyy Aug 30, 2018

guillaumedebavelaere Aug 30, 2018

gigiyy Aug 30, 2018

guillaumedebavelaere Aug 30, 2018

gigiyy Aug 30, 2018

guillaumedebavelaere Aug 30, 2018

guillaumedebavelaere Aug 30, 2018

gigiyy Aug 30, 2018

guillaumedebavelaere Aug 30, 2018

gigiyy Aug 30, 2018

guillaumedebavelaere Aug 30, 2018

gigiyy Aug 30, 2018

guillaumedebavelaere Aug 30, 2018

gigiyy commented Aug 30, 2018

guillaumedebavelaere commented Aug 30, 2018 •

edited

Loading

gigiyy commented Aug 30, 2018

guillaumedebavelaere commented Aug 31, 2018

guillaumedebavelaere commented Aug 31, 2018

Gz/convert to kotlin #100

Gz/convert to kotlin #100

Conversation

gigiyy commented Aug 14, 2018

guillaumedebavelaere commented Aug 23, 2018

oliver-was-here commented Aug 23, 2018

oliver-was-here commented Aug 24, 2018

guillaumedebavelaere left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gigiyy commented Aug 30, 2018

guillaumedebavelaere commented Aug 30, 2018 • edited Loading

gigiyy commented Aug 30, 2018

guillaumedebavelaere commented Aug 31, 2018

guillaumedebavelaere commented Aug 31, 2018

guillaumedebavelaere commented Aug 30, 2018 •

edited

Loading