Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.65.1 to 1.66.1 in /rspec-distrib #54

Merged
merged 4 commits into from
Sep 12, 2024
Merged

Bump rubocop from 1.65.1 to 1.66.1 in /rspec-distrib #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e7b90a4
Bump rubocop from 1.65.1 to 1.66.1 in /rspec-distrib
dependabot[bot] Sep 12, 2024
69bdfab
Fixup
sasha370 Sep 12, 2024
3489a11
Merge branch 'main' into dependabot-bundler-rspec-distrib-rubocop-1.66.1
sasha370 Sep 12, 2024
2e98c55
Merge branch 'main' into dependabot-bundler-rspec-distrib-rubocop-1.66.1
sasha370 Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions rspec-distrib/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ GEM
json (2.7.2)
language_server-protocol (3.17.0.3)
method_source (1.1.0)
parallel (1.26.2)
parser (3.3.4.2)
parallel (1.26.3)
parser (3.3.5.0)
ast (~> 2.4.1)
racc
pry (0.14.2)
Expand All @@ -35,8 +35,6 @@ GEM
rainbow (3.1.1)
rake (13.2.1)
regexp_parser (2.9.2)
rexml (3.3.6)
strscan
rspec (3.13.0)
rspec-core (~> 3.13.0)
rspec-expectations (~> 3.13.0)
Expand All @@ -50,18 +48,17 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
rubocop (1.65.1)
rubocop (1.66.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.4, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.31.1, < 2.0)
rubocop-ast (>= 1.32.2, < 2.0)
ruby-progressbar (~> 1.7)
unicode-display_width (>= 2.4.0, < 3.0)
rubocop-ast (1.32.0)
rubocop-ast (1.32.3)
parser (>= 3.3.1.0)
rubocop-rspec (3.0.4)
rubocop (~> 1.61)
Expand All @@ -72,7 +69,6 @@ GEM
simplecov_json_formatter (~> 0.1)
simplecov-html (0.12.3)
simplecov_json_formatter (0.1.4)
strscan (3.1.0)
unicode-display_width (2.5.0)
yard (0.9.36)

Expand Down
2 changes: 0 additions & 2 deletions rspec-distrib/lib/rspec/distrib/worker/rspec_runner.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ def init_formatters
#
# @param reporter [RSpec::Core::Reporter]
#
# @return [Boolean] true in case there were no failures.
Copy link
Contributor

@sasha370 sasha370 Sep 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not true.

# rubocop:disable Metrics/AbcSize,Metrics/MethodLength,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity
def consume_queue(reporter)
@reported_examples = []
Expand Down Expand Up @@ -120,7 +119,6 @@ def consume_queue(reporter)
ensure
# Putting examples back to the local reporter, so that results are consistent.
reporter.examples.concat(@reported_examples)
false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix rubocop

end
# rubocop:enable Metrics/AbcSize,Metrics/MethodLength,Metrics/CyclomaticComplexity,Metrics/PerceivedComplexity

Expand Down