-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rubocop from 1.65.1 to 1.66.1 in /rspec-distrib #54
Merged
sasha370
merged 4 commits into
main
from
dependabot-bundler-rspec-distrib-rubocop-1.66.1
Sep 12, 2024
Merged
Bump rubocop from 1.65.1 to 1.66.1 in /rspec-distrib #54
sasha370
merged 4 commits into
main
from
dependabot-bundler-rspec-distrib-rubocop-1.66.1
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sasha370
approved these changes
Sep 12, 2024
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.65.1 to 1.66.1. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.65.1...v1.66.1) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
force-pushed
the
dependabot-bundler-rspec-distrib-rubocop-1.66.1
branch
from
September 12, 2024 03:30
22004ec
to
e7b90a4
Compare
sasha370
reviewed
Sep 12, 2024
@@ -87,7 +87,6 @@ def init_formatters | |||
# | |||
# @param reporter [RSpec::Core::Reporter] | |||
# | |||
# @return [Boolean] true in case there were no failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true.
sasha370
reviewed
Sep 12, 2024
@@ -120,7 +119,6 @@ def consume_queue(reporter) | |||
ensure | |||
# Putting examples back to the local reporter, so that results are consistent. | |||
reporter.examples.concat(@reported_examples) | |||
false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix rubocop
AlexDavidoiu
approved these changes
Sep 12, 2024
sasha370
deleted the
dependabot-bundler-rspec-distrib-rubocop-1.66.1
branch
September 12, 2024 07:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps rubocop from 1.65.1 to 1.66.1.
Release notes
Sourced from rubocop's releases.
... (truncated)
Changelog
Sourced from rubocop's changelog.
... (truncated)
Commits
ba8e7be
Cut 1.66.12900c91
Update Changelog08bed81
Fix an error forStyle/IfWithSemicolon
c2ae362
Don't parse YAML twice5f3481f
Userubocop-ast
SimpleForwardable
5e65a39
Merge pull request #13185 from vlad-pisanov/vp_map_into_array_2d18b3c9
Fix false negatives inStyle/MapIntoArray
autocorrection when using `ensure...3277118
[Fix #13182] Tweak the doc forStyle/RedundantInterpolationUnfreeze
9a38b11
Merge pull request #13179 from Earlopain/node-matcher-directiry-errorfd4f4d7
Fix an error forInternalAffairs/NodeMatcherDirective
when no second argumentDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)