Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distrib-core as dependency of rspec-distrib #13

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Add distrib-core as dependency of rspec-distrib #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions rspec-distrib/Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ PATH
remote: .
specs:
rspec-distrib (0.0.1)
distrib-core
rspec-core (~> 3.12)

GEM
Expand Down
1 change: 1 addition & 0 deletions rspec-distrib/rspec-distrib.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ Gem::Specification.new do |s|
s.bindir = 'exe'
s.executables = ['rspec-distrib']

s.add_dependency 'distrib-core'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could specify version range, while I don't have clear idea on how should it be.
Will be keep versioning both gems the same? or maybe use '~> 0.0.1 for now?

Copy link
Contributor

@mbie mbie Jun 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's start with 0.0.1 for now.

s.add_dependency 'rspec-core', '~> 3.12'

s.metadata['rubygems_mfa_required'] = 'true'
Expand Down