Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distrib-core as dependency of rspec-distrib #13

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

kml
Copy link
Contributor

@kml kml commented Jun 14, 2024

Both distrib-core and rspec-distrib are published gems. That means we could finally express their relation in the gemspec.

@kml kml added the DevX label Jun 14, 2024
@kml kml self-assigned this Jun 14, 2024
@@ -16,6 +16,7 @@ Gem::Specification.new do |s|
s.bindir = 'exe'
s.executables = ['rspec-distrib']

s.add_dependency 'distrib-core'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could specify version range, while I don't have clear idea on how should it be.
Will be keep versioning both gems the same? or maybe use '~> 0.0.1 for now?

Copy link
Contributor

@mbie mbie Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's start with 0.0.1 for now.

@kml kml marked this pull request as ready for review June 14, 2024 14:47
@kml kml requested a review from a team as a code owner June 14, 2024 14:47
@kml
Copy link
Contributor Author

kml commented Jun 14, 2024

@toptal-anvil ping reviewers

@kml kml enabled auto-merge (squash) June 17, 2024 07:52
@kml kml requested a review from a team June 17, 2024 07:52
@kml kml merged commit a57c7ed into main Jun 17, 2024
5 checks passed
@kml kml deleted the add-distrib-core-as-dependency-of-rspec-distrib branch June 17, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants