fix: update slot translation when language changes #3340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, @EugeneBalabai e2e tests are failing, would you be able to look at it? This bug with slots should be easily testable in the example app. Let me know if you need help with e2e tests. |
|
@stepan662 it should work now |
stepan662
approved these changes
Jun 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translations in slots are not updated when the language changes.
Expected Result
When the language changes, all translations, including those in slots, should update dynamically.
Current Result
Translations in slots remain unchanged when the language is changed, requiring a manual refresh to update.
Reproduction
You can see the issue in this CodeSandbox.