feat: vue named slot syntax #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepan662
requested changes
Apr 14, 2024
stepan662
reviewed
Apr 15, 2024
stepan662
approved these changes
Apr 15, 2024
|
@stepan662 I made a mistake. The Currently, I don't see a really good solution. Only move slots execution to the render function. Maybe you have a better idea. |
|
If the moving to render function works, I think the solution is fine. Or are there some drawbacks? |
|
I would like to use Vue reactivity. But since the $slots object is not reactive, I don’t see any other solutions. I will create PR created: #3340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
Tolgee Vuelibrary doesn't support localizing messages that contain HTML tags or components, causing inconvenience for our team and potentially for others in the community.Inspired by the approach in
Vue-i18n's Component Interpolation (explained here), these changes introduce named slots for string interpolation.