refactor(editor): extract adapters to shared #9344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
donteatfriedrice
changed the title
doodlewind
approved these changes
Dec 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #9344 +/- ##
==========================================
- Coverage 51.45% 51.43% -0.02%
==========================================
Files 2156 2156
Lines 97654 97654
Branches 16377 16377
==========================================
- Hits 50247 50233 -14
- Misses 46017 46031 +14
Partials 1390 1390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extract_notion_html_adapter_to_shared
branch
from
d32e834 to
8501c69
Compare
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extrac_adapters_to_shared
branch
from
4e4886f to
2f54bd6
Compare
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extract_notion_html_adapter_to_shared
branch
from
8501c69 to
79c4f5b
Compare
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extrac_adapters_to_shared
branch
from
2f54bd6 to
4baa691
Compare
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extract_notion_html_adapter_to_shared
branch
from
79c4f5b to
cf2f9f3
Compare
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extrac_adapters_to_shared
branch
from
4baa691 to
0a08df6
Compare
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extract_notion_html_adapter_to_shared
branch
from
f4c8be2 to
47c7e2f
Compare
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extrac_adapters_to_shared
branch
2 times, most recently
from
65e1608 to
807f008
Compare
Merge activity
|
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extract_notion_html_adapter_to_shared
branch
from
47c7e2f to
4a3caaf
Compare
donteatfriedrice
added a commit
that referenced
this pull request
Dec 27, 2024
Extract AttachmentAdapter, ImageAdapter, NotionTextAdapter to shared.
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extrac_adapters_to_shared
branch
from
807f008 to
ae4f10a
Compare
Base automatically changed from
12-26-refactor_editor_extract_notion_html_adapter_to_shared
to
canary
December 27, 2024 08:16
Extract AttachmentAdapter, ImageAdapter, NotionTextAdapter to shared.
donteatfriedrice
force-pushed
the
12-26-refactor_editor_extrac_adapters_to_shared
branch
from
ae4f10a to
fee8630
Compare
graphite-app
bot
deleted the
12-26-refactor_editor_extrac_adapters_to_shared
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract AttachmentAdapter, ImageAdapter, NotionTextAdapter to shared.