Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): extract notion html adapter to shared #9341

Conversation

donteatfriedrice
Copy link
Member

No description provided.

@donteatfriedrice donteatfriedrice marked this pull request as ready for review December 26, 2024 09:38
@donteatfriedrice donteatfriedrice requested a review from a team as a code owner December 26, 2024 09:38
@github-actions github-actions bot added the test Related to test cases label Dec 26, 2024
@graphite-app graphite-app bot requested a review from forehalo December 26, 2024 09:38
Copy link
Member Author

donteatfriedrice commented Dec 26, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@donteatfriedrice donteatfriedrice force-pushed the 12-26-refactor_editor_extract_notion_html_adapter_to_shared branch from 35d3ae8 to 2998336 Compare December 26, 2024 09:39
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.45%. Comparing base (6fcdd01) to head (4a3caaf).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9341      +/-   ##
==========================================
- Coverage   51.68%   51.45%   -0.23%     
==========================================
  Files        2156     2156              
  Lines       97651    97651              
  Branches    16416    16379      -37     
==========================================
- Hits        50467    50247     -220     
- Misses      45793    46016     +223     
+ Partials     1391     1388       -3     
Flag Coverage Δ
server-test 78.31% <ø> (-0.66%) ⬇️
unittest 31.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donteatfriedrice donteatfriedrice force-pushed the 12-26-refactor_editor_extract_notion_html_adapter_to_shared branch 3 times, most recently from 79c4f5b to cf2f9f3 Compare December 26, 2024 11:09
@graphite-app graphite-app bot requested review from CatsJuice, EYHN, JimmFly and pengx17 and removed request for EYHN December 27, 2024 06:17
@donteatfriedrice donteatfriedrice force-pushed the 12-26-refactor_editor_extract_notion_html_adapter_to_shared branch from f4c8be2 to 47c7e2f Compare December 27, 2024 06:21
Copy link

graphite-app bot commented Dec 27, 2024

Merge activity

@donteatfriedrice donteatfriedrice force-pushed the 12-26-refactor_editor_extract_notion_html_adapter_to_shared branch from 47c7e2f to 4a3caaf Compare December 27, 2024 08:00
@graphite-app graphite-app bot merged commit 4a3caaf into canary Dec 27, 2024
61 checks passed
@graphite-app graphite-app bot deleted the 12-26-refactor_editor_extract_notion_html_adapter_to_shared branch December 27, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants