Add enable_pipelined_commit as deprecated option #397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
LykxSassinator
approved these changes
Oct 30, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable_pipelined_commitwas introduced by TiKV before, but got renamed toenable_multi_batch_writelater. However, there are some versions of TiKV still running withenable_pipelined_commit(either false or true) persisted inOPTIONS-xxxxfile under RocksDB directory, when upgrading these TiKVs, they will panic because of "load_latest_options" who reads theOPTIONS-xxxxdoes not recognize the option.Now, add this option as a deprecated option, so that, it won't cause a
InvalidArgumentpanic, nor will it be serialized inOPTIONS-xxxxfiles anymore.