Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-batches write implementation #387

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

v01dstar
Copy link

@v01dstar v01dstar commented Sep 29, 2024

Optimize the waiting delay caused by the uneven load of the writer wb: the writer who enters the request queue later enters the commit phase first.

It combines:

@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 29, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 29, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 30, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 30, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 30, 2024
Copy link

ti-chi-bot bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Connor1996, glorv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 30, 2024
Copy link

ti-chi-bot bot commented Sep 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-29 09:29:07.550961522 +0000 UTC m=+174302.971174534: ☑️ agreed by Connor1996.
  • 2024-09-29 09:33:56.894976752 +0000 UTC m=+174592.315189764: ☑️ agreed by glorv.
  • 2024-09-30 03:48:00.005790231 +0000 UTC m=+240235.426003228: ✖️🔁 reset by glorv.
  • 2024-09-30 06:24:51.189867133 +0000 UTC m=+249646.610080138: ☑️ agreed by glorv.
  • 2024-09-30 06:55:21.655224386 +0000 UTC m=+251477.075437397: ☑️ agreed by Connor1996.

@ti-chi-bot ti-chi-bot bot merged commit 56fb1ab into tikv:8.10.tikv Sep 30, 2024
5 checks passed
@v01dstar v01dstar deleted the multi-batches-write branch September 30, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants