-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump three dependencies #250
Conversation
Signed-off-by: ice1000 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why? Does this mean we have to drop rust 1.31 support? |
The crate getrandom only supports Rust 1.32 and later (see https://github.com/rust-random/getrandom and brief discussion at rust-random/getrandom#15 (review)), so if we want to keep that dep, then I think we to drop 1.31 support (which isn't such a bad thing, IMO we should only support current stable). |
Ok (and it sounds like it's not an issue of my own dependency bump) |
PTAL @Hoverbear |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think we can also remove Hashbrown soon?
Signed-off-by: ice1000 [email protected]
As title.