Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump three dependencies #250

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Bump three dependencies #250

merged 2 commits into from
Jul 3, 2019

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jul 1, 2019

Signed-off-by: ice1000 [email protected]

As title.

Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ice1000
Copy link
Contributor Author

ice1000 commented Jul 1, 2019

error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.1.6/src/error_impls.rs:13:5
   |
8  | extern crate std;
   | ----------------- not an extern crate passed with `--extern`
...
13 | use std::{error, io};
   |     ^^^
   |
note: this import refers to the extern crate imported here
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.1.6/src/error_impls.rs:8:1
   |
8  | extern crate std;
   | ^^^^^^^^^^^^^^^^^
                                                                                
error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.1.6/src/use_file.rs:15:5
   |
10 | extern crate std;
   | ----------------- not an extern crate passed with `--extern`
...
15 | use std::{fs::File, io::Read};
   |     ^^^
   |
note: this import refers to the extern crate imported here
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.1.6/src/use_file.rs:10:1
   |
10 | extern crate std;
   | ^^^^^^^^^^^^^^^^^
                                                                                
error[E0658]: imports can only refer to extern crate names passed with `--extern` on stable channel (see issue #53130)
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.1.6/src/linux_android.rs:15:5
   |
10 | extern crate std;
   | ----------------- not an extern crate passed with `--extern`
...
15 | use std::io;
   |     ^^^
   |
note: this import refers to the extern crate imported here
  --> /home/travis/.cargo/registry/src/github.com-1ecc6299db9ec823/getrandom-0.1.6/src/linux_android.rs:10:1
   |
10 | extern crate std;
   | ^^^^^^^^^^^^^^^^^
                                                                                
error: aborting due to 3 previous errors

Why? Does this mean we have to drop rust 1.31 support?

@nrc
Copy link
Contributor

nrc commented Jul 1, 2019

The crate getrandom only supports Rust 1.32 and later (see https://github.com/rust-random/getrandom and brief discussion at rust-random/getrandom#15 (review)), so if we want to keep that dep, then I think we to drop 1.31 support (which isn't such a bad thing, IMO we should only support current stable).

@ice1000
Copy link
Contributor Author

ice1000 commented Jul 2, 2019

The crate getrandom only supports Rust 1.32 and later (see https://github.com/rust-random/getrandom and brief discussion at rust-random/getrandom#15 (review)), so if we want to keep that dep, then I think we to drop 1.31 support (which isn't such a bad thing, IMO we should only support current stable).

Ok (and it sounds like it's not an issue of my own dependency bump)

@ice1000
Copy link
Contributor Author

ice1000 commented Jul 3, 2019

PTAL @Hoverbear

Copy link
Contributor

@Hoverbear Hoverbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can also remove Hashbrown soon?

@Hoverbear Hoverbear added this to the 0.6.0 milestone Jul 3, 2019
@Hoverbear Hoverbear merged commit 90ffe0c into tikv:master Jul 3, 2019
@ice1000 ice1000 deleted the deps branch July 3, 2019 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants