Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum supported rust version from 1.31 to 1.32 #253

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Bump minimum supported rust version from 1.31 to 1.32 #253

merged 2 commits into from
Jul 2, 2019

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jul 2, 2019

Signed-off-by: ice1000 [email protected]

As title. According to #250 (comment)

@ice1000 ice1000 changed the title Bump minimum supported rust version from 1.31 to 1.35 Bump minimum supported rust version from 1.31 to 1.3 Jul 2, 2019
@ice1000 ice1000 changed the title Bump minimum supported rust version from 1.31 to 1.3 Bump minimum supported rust version from 1.31 to 1.32 Jul 2, 2019
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a comment about this in the README please?

@ice1000
Copy link
Contributor Author

ice1000 commented Jul 2, 2019

error[E0658]: `cfg(target_vendor)` is experimental and subject to change (see issue #29718)
   --> C:\Users\travis\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.32\src\lib.rs:147:45
    |
147 | #[cfg(all(windows, feature = "dbghelp", not(target_vendor = "uwp")))]
    |                                             ^^^^^^^^^^^^^^^^^^^^^
error[E0658]: `cfg(target_vendor)` is experimental and subject to change (see issue #29718)
   --> C:\Users\travis\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.32\src\backtrace\mod.rs:140:59
    |
140 |     } else if #[cfg(all(windows, feature = "dbghelp", not(target_vendor = "uwp")))] {
    |                                                           ^^^^^^^^^^^^^^^^^^^^^
error[E0658]: `cfg(target_vendor)` is experimental and subject to change (see issue #29718)
   --> C:\Users\travis\.cargo\registry\src\github.com-1ecc6299db9ec823\backtrace-0.3.32\src\symbolize\mod.rs:462:52
    |
462 |                         any(unix, all(windows, not(target_vendor = "uwp"), target_env = "gnu")),
    |                                                    ^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 3 previous errors

Seems that we have to bump to 1.33?

Signed-off-by: ice1000 <[email protected]>
@ice1000
Copy link
Contributor Author

ice1000 commented Jul 2, 2019

PTAL @nrc @Hoverbear

Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nrc nrc merged commit 44940d1 into tikv:master Jul 2, 2019
@ice1000 ice1000 deleted the sticky-fingers branch July 2, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants