Skip to content

remove uses_cxx11 call in build_grpc causing macos build failure #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions cross_compile.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,7 @@ yum install mingw64-openssl-static mingw64-zlib-static mingw64-winpthreads-stati
.define("CMAKE_SYSTEM_PROCESSOR", get_env("CARGO_CFG_TARGET_ARCH").unwrap())
.define("CMAKE_CROSSCOMPILING", "true")
.build_target(library)
.uses_cxx11()
.build()
// config.build_target(library).uses_cxx11().build()
};
```

Expand Down
2 changes: 1 addition & 1 deletion src/call/client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@ impl<Req> StreamingCallSink<Req> {
/// The rules are listed as below:
/// - All messages except the last one will be sent with `buffer_hint` set to true.
/// - The last message will also be sent with `buffer_hint` set to true unless any message is
/// offered with buffer hint set to false.
/// offered with buffer hint set to false.
///
/// No matter `enhance_batch` is true or false, it's recommended to follow the contract of
/// Sink and call `poll_flush` to ensure messages are handled by gRPC C Core.
Expand Down
26 changes: 13 additions & 13 deletions src/call/server.rs
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ macro_rules! impl_stream_sink {
/// The rules are listed as below:
/// - All messages except the last one will be sent with `buffer_hint` set to true.
/// - The last message will also be sent with `buffer_hint` set to true unless any message is
/// offered with buffer hint set to false.
/// offered with buffer hint set to false.
///
/// No matter `enhance_batch` is true or false, it's recommended to follow the contract of
/// Sink and call `poll_flush` to ensure messages are handled by gRPC C Core.
Expand Down Expand Up @@ -617,24 +617,24 @@ macro_rules! impl_stream_sink {
}

impl_stream_sink!(
/// A sink for server streaming call.
///
/// To close the sink properly, you should call [`close`] or [`fail`] before dropping.
///
/// [`close`]: #method.close
/// [`fail`]: #method.fail
/// A sink for server streaming call.
///
/// To close the sink properly, you should call [`close`] or [`fail`] before dropping.
///
/// [`close`]: #method.close
/// [`fail`]: #method.fail
#[must_use = "if unused the sink may immediately cancel the RPC"]
ServerStreamingSink,
ServerStreamingSinkFailure,
ShareCall
);
impl_stream_sink!(
/// A sink for duplex streaming call.
///
/// To close the sink properly, you should call [`close`] or [`fail`] before dropping.
///
/// [`close`]: #method.close
/// [`fail`]: #method.fail
/// A sink for duplex streaming call.
///
/// To close the sink properly, you should call [`close`] or [`fail`] before dropping.
///
/// [`close`]: #method.close
/// [`fail`]: #method.fail
#[must_use = "if unused the sink may immediately cancel the RPC"]
DuplexSink,
DuplexSinkFailure,
Expand Down
12 changes: 6 additions & 6 deletions src/metadata.rs
Original file line number Diff line number Diff line change
Expand Up @@ -143,18 +143,18 @@ impl Clone for MetadataBuilder {
///
/// - Request headers
///
/// They are sent by the client at the beginning of a remote call before
/// any request messages are sent.
/// They are sent by the client at the beginning of a remote call before
/// any request messages are sent.
///
/// - Response headers
///
/// They are sent by the server at the beginning of a remote call handler
/// before any response messages are sent.
/// They are sent by the server at the beginning of a remote call handler
/// before any response messages are sent.
///
/// - Response trailers
///
/// They are sent by the server at the end of a remote call along with
/// resulting call status.
/// They are sent by the server at the end of a remote call along with
/// resulting call status.
///
/// Metadata value can be ascii string or bytes. They are distinguish by the
/// key suffix, key of bytes value should have suffix '-bin'.
Expand Down