-
Notifications
You must be signed in to change notification settings - Fork 258
remove uses_cxx11 call in build_grpc causing macos build failure #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
remove uses_cxx11 call in build_grpc causing macos build failure #657
Conversation
Welcome @taddes! It looks like this is your first PR to tikv/grpc-rs 🎉 |
Hey @BusyJay , just have an issue with the DCO signoff as the instructions link to a dead end in the ti-chi-bot. My commits are GPG signed against my Mozilla email. Would you let me know what I need to do to unblock on this? Unfortunately, there's no contributing doc I could reference in the repo. Thanks! |
Detail signoff instructions can be found here: https://github.com/tikv/grpc-rs/pull/657/checks?check_run_id=40342515992 |
8492fd1
to
e49143f
Compare
Thanks @BusyJay , lmk if you're comfortable moving this to your main workflow for review and approval. |
39266d7
to
8da6c50
Compare
7e59457
to
bd46a22
Compare
Signed-off-by: Taddes <[email protected]>
Signed-off-by: Taddes <[email protected]>
…ed-off-by: Taddes <[email protected]> Signed-off-by: Taddes <[email protected]>
Signed-off-by: Taddes <[email protected]>
b5b6a7c
to
20271a2
Compare
Hey @BusyJay , I've got the fix in place and made a lot of clippy adjustments to satisfy, but there are a considerable number of warnings regarding |
OK, I will take a look and make a fix for those warnings in a separate PR. Thanks for your work! |
Thanks a bunch @BusyJay ! Just keep me posted and when we can land this change on top of that! Will look for future opportunities to contribute since I've got my feet wet here. Appreciate the warm welcome and appreciate your work! |
Hi @taddes, now CI should work, feel free to merge master when you have time. |
Thanks @BusyJay !! |
Btw, in my forked repo and branch, I get a message that I don't have proper access rights to do a |
No, this repo is public. Make sure the upstream url is using https protocol. |
That did it, didn't know why it was originally working but then for pulling down from remote. Must have defaulted to HTTP. Checks are running and then should hopefully be good to go @BusyJay |
Resolution of MacOS build issue I outlined in #654 and related context to cc-rs and cmake. I'd suggested removing
uses_cx11
, which was confusingly appending to the system output of OS value and also removing the example from the documentation comment and example in cross_compile.md under All diff in fn build_grpc