Skip to content

remove uses_cxx11 call in build_grpc causing macos build failure #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

taddes
Copy link

@taddes taddes commented Apr 10, 2025

Resolution of MacOS build issue I outlined in #654 and related context to cc-rs and cmake. I'd suggested removing uses_cx11, which was confusingly appending to the system output of OS value and also removing the example from the documentation comment and example in cross_compile.md under All diff in fn build_grpc

Copy link

ti-chi-bot bot commented Apr 10, 2025

Welcome @taddes! It looks like this is your first PR to tikv/grpc-rs 🎉

@taddes
Copy link
Author

taddes commented Apr 10, 2025

Hey @BusyJay , just have an issue with the DCO signoff as the instructions link to a dead end in the ti-chi-bot. My commits are GPG signed against my Mozilla email. Would you let me know what I need to do to unblock on this? Unfortunately, there's no contributing doc I could reference in the repo. Thanks!

@BusyJay
Copy link
Member

BusyJay commented Apr 11, 2025

Detail signoff instructions can be found here: https://github.com/tikv/grpc-rs/pull/657/checks?check_run_id=40342515992

@taddes taddes force-pushed the bugfix/remove_uses_cxx11_macos_build_issue branch from 8492fd1 to e49143f Compare April 11, 2025 17:33
@taddes
Copy link
Author

taddes commented Apr 11, 2025

Thanks @BusyJay , lmk if you're comfortable moving this to your main workflow for review and approval.

@taddes taddes force-pushed the bugfix/remove_uses_cxx11_macos_build_issue branch from b5b6a7c to 20271a2 Compare April 15, 2025 19:55
@taddes
Copy link
Author

taddes commented Apr 15, 2025

Hey @BusyJay , I've got the fix in place and made a lot of clippy adjustments to satisfy, but there are a considerable number of warnings regarding error: creating a mutable reference to mutable static is discouraged. See the recent CI check outputs for most platforms. This kind of goes beyond the scope of this contribution, and since these code blocks are run within unsafe areas, I am not sure if my tinkering with this makes sense, or if it's best to simply ignore the check outputs since it was designed this way. Just let me know how you want to proceed as I do not have the historical context on this project to make an informed decision.

@BusyJay
Copy link
Member

BusyJay commented Apr 16, 2025

OK, I will take a look and make a fix for those warnings in a separate PR. Thanks for your work!

@taddes
Copy link
Author

taddes commented Apr 17, 2025

Thanks a bunch @BusyJay ! Just keep me posted and when we can land this change on top of that! Will look for future opportunities to contribute since I've got my feet wet here. Appreciate the warm welcome and appreciate your work!

@BusyJay
Copy link
Member

BusyJay commented May 5, 2025

Hi @taddes, now CI should work, feel free to merge master when you have time.

@taddes
Copy link
Author

taddes commented May 5, 2025

Thanks @BusyJay !!

@taddes
Copy link
Author

taddes commented May 5, 2025

Btw, in my forked repo and branch, I get a message that I don't have proper access rights to do a git fetch, since I want to integrate the upstream changes you made. Do I have to be added to an ACL or something?

@BusyJay
Copy link
Member

BusyJay commented May 6, 2025

No, this repo is public. Make sure the upstream url is using https protocol.

@taddes
Copy link
Author

taddes commented May 12, 2025

That did it, didn't know why it was originally working but then for pulling down from remote. Must have defaulted to HTTP. Checks are running and then should hopefully be good to go @BusyJay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants