Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulseaudio direct connection #852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

josa41
Copy link
Contributor

@josa41 josa41 commented Oct 17, 2024

Set Ghaf audio apps to directly connect to audiovm with pulseaudio

Description of changes

Makes app vms use audiovm pulseaudio directly without application audio tunneling
With this change the pulseaudio don't move patch is not needed

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Appvm audio routing has changed, audio should work same as before

Instructions for Testing

  • List all targets that this applies to: Lenovo X1, Dell-Latitude
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality? no changes

Set Ghaf audio apps to directly connect to audiovm with pulseaudio
With this change we can also remove the pulseaudio don't move patch

Signed-off-by: Jon Sahlberg <[email protected]>
@josa41 josa41 requested a review from nesteroff October 17, 2024 13:19
@josa41 josa41 temporarily deployed to internal-build-workflow October 17, 2024 13:19 — with GitHub Actions Inactive
@josa41 josa41 added the Needs Testing CI Team to pre-verify label Oct 17, 2024
@josa41 josa41 mentioned this pull request Oct 18, 2024
15 tasks
environment = {
systemPackages = [ pkgs.pulseaudio ];
sessionVariables = rec {
PULSE_SERVER = "${address}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this should be an option, as some applications do not respect/read this environment variable and just connect to localhost.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good comment, yes that was one of the original reasons for the previous implementation.
There were some complaints that with the earlier setup the TCP tunnel remains open after the application is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Testing CI Team to pre-verify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants