Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GhafPkgs] Update Audio Control #850

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

baz2142
Copy link
Contributor

@baz2142 baz2142 commented Oct 16, 2024

Add AppVM names support. Now you can see, which stream belongs to which AppVM

Description of changes

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

Run Audio Control
Run Chromium and check, that steams appear under "Chromium-appvm" name
Another audio apps, if it is possible

@baz2142 baz2142 temporarily deployed to internal-build-workflow October 16, 2024 09:29 — with GitHub Actions Inactive
@baz2142 baz2142 added the Needs Testing CI Team to pre-verify label Oct 16, 2024
@baz2142 baz2142 self-assigned this Oct 16, 2024
@baz2142 baz2142 temporarily deployed to internal-build-workflow October 16, 2024 10:48 — with GitHub Actions Inactive
@leivos-unikie
Copy link
Contributor

leivos-unikie commented Oct 16, 2024

Tested on Lenovo-X1 (rebuild switch)

  • ci-test-automation pass
  • all menu icons work
  • audio control tool shows streams by vm name but there is strange note "No streams from the AppVM" although I am listening sound from that particular app-vm

screenshot-20241016-14-59-42

Add AppVM names support

Signed-off-by: Nikita Bazulin <[email protected]>
@baz2142 baz2142 temporarily deployed to internal-build-workflow October 17, 2024 08:08 — with GitHub Actions Inactive
@leivos-unikie
Copy link
Contributor

Also noticed now that the audio streams stay open although corresponding apps are closed. Is this ok?

@leivos-unikie leivos-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Oct 17, 2024
@brianmcgillion brianmcgillion merged commit 05e1a2f into tiiuae:main Oct 18, 2024
14 checks passed
@baz2142
Copy link
Contributor Author

baz2142 commented Oct 18, 2024

Also noticed now that the audio streams stay open although corresponding apps are closed. Is this ok?

I think, now every AppVM has it's own stream for the all apps. So it's not like every application inside an AppVM creates a stream, but every application inside it goes through the same stream

Is it correct, @josa41?

@josa41
Copy link
Contributor

josa41 commented Oct 18, 2024

Also noticed now that the audio streams stay open although corresponding apps are closed. Is this ok?

I think, now every AppVM has it's own stream for the all apps. So it's not like every application inside an AppVM creates a stream, but every application inside it goes through the same stream

Is it correct, @josa41?

Yes in current version the app-vm created the pulseaudio tcp tunnel open even though the app is closed. The actual pulseaudio application audio stream is closed but tcp tunnel that carries the stream stays open.
From audio-vm
pactl list sink-inputs or pactl list source-outputs should show the actual application audio streams

I have made a patch that would fix the tcp stream so that the connection will get closed along with the app: #852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants