Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom cache option when creating controller manager #3576

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Remove custom cache option when creating controller manager #3576

merged 3 commits into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. Remove custom cache option when creating controller manager 

    This change removes the Calico v3 object cache option introduced in [1].
Since v0.16.0, the controller-runtime has been updated such that cache
configs can be specified per-namespace [2]. The specific change breaks
our operator because runtime now contacts the API server (via dynamic
rest mapper) to determine if a cache config type (e.g. network policy) is
namespaced. The custom cache config is no longer needed after recent
changes to how network policy is listed by Tigera apiserver.

[1] https://github.com/tigera/operator/pull/1970/files#r891164239
[2] https://github.com/kubernetes-sigs/controller-runtime/pull/2421/files#diff-964e351ee2375d359c78d69e514c4edc42577219761c4475f391ed2daf715e51R368
    @hjiawei
    hjiawei committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    fb86f06 View commit details
    Browse the repository at this point in the history

  2. make gen-versions

    @hjiawei
    hjiawei committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    0ed21e8 View commit details
    Browse the repository at this point in the history

  3. Update k8s test utilities

    @hjiawei
    hjiawei committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    8fe7d71 View commit details
    Browse the repository at this point in the history