Remove custom cache option when creating controller manager #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the Calico v3 object cache option introduced in [1]. Since v0.16.0, the controller-runtime has been updated such that cache configs can be specified per-namespace [2]. The specific change breaks our operator because runtime now contacts the API server (via dynamic rest mapper) to determine if a cache config type (e.g. network policy) is namespaced. The custom cache config is no longer needed after recent changes to how network policy is listed by Tigera apiserver. [1] https://github.com/tigera/operator/pull/1970/files#r891164239 [2] https://github.com/kubernetes-sigs/controller-runtime/pull/2421/files#diff-964e351ee2375d359c78d69e514c4edc42577219761c4475f391ed2daf715e51R368
hjiawei
force-pushed
the
remove-v3obj-cache
branch
from
d538963
to
fb86f06
Compare
hjiawei
commented
Oct 29, 2024
| @@ -298,7 +298,7 @@ run-fvs: | |||
|
|
|||
| ## Create a local kind dual stack cluster. | |||
| KIND_KUBECONFIG?=./kubeconfig.yaml | |||
| K8S_VERSION?=v1.21.14 | |||
| KINDEST_NODE_VERSION?=v1.30.4 | |||
There was a problem hiding this comment.
This is required to pass operator FVs. kindest/node v1.21 release will give errors on watch/list ValidatingAdmissionPolicy and ValidatingAdmissionBinding resources.
caseydavenport
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the Calico v3 object cache option introduced in [1]. Since v0.16.0, the controller-runtime has been updated such that cache configs can be specified per-namespace [2]. The specific change breaks our operator because runtime now contacts the API server (via dynamic rest mapper) to determine if a cache config type (e.g. network policy) is namespaced. The custom cache config is no longer needed after recent changes to how network policy is listed by Tigera apiserver.
[1] https://github.com/tigera/operator/pull/1970/files#r891164239
[2] https://github.com/kubernetes-sigs/controller-runtime/pull/2421/files#diff-964e351ee2375d359c78d69e514c4edc42577219761c4475f391ed2daf715e51R368
For PR author
make gen-filesmake gen-versionsFor PR reviewers
A note for code reviewers - all pull requests must have the following:
kind/bugif this is a bugfix.kind/enhancementif this is a a new feature.enterpriseif this PR applies to Calico Enterprise only.