-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update record classes for CoMLOPs format #163
Open
ktro2828
wants to merge
7
commits into
main
Choose a base branch
from
feat/comlops/rosbag-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,032
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ktro2828 <[email protected]>
ktro2828
force-pushed
the
feat/comlops/rosbag-conversion
branch
from
October 29, 2024 15:27
43fcfde
to
6d9648e
Compare
Signed-off-by: ktro2828 <[email protected]>
This was referenced Nov 11, 2024
miursh
reviewed
Nov 11, 2024
Co-authored-by: Shunsuke Miura <[email protected]>
TODO List
|
@ktro2828 |
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
Signed-off-by: ktro2828 <[email protected]>
NOTE
|
@miursh |
ktro2828
force-pushed
the
feat/comlops/rosbag-conversion
branch
5 times, most recently
from
November 13, 2024 07:25
b234e5f
to
58510af
Compare
Signed-off-by: ktro2828 <[email protected]>
ktro2828
force-pushed
the
feat/comlops/rosbag-conversion
branch
from
November 13, 2024 07:29
58510af
to
a79b5c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes following changes:
ego_pose
and store data recorded by INSvehicle_state.json
Configuration updates
As described in
config/convert_comlops_rosbag2_to_non_annotated_t4_sample.yaml
, please edit fields inconversion
as follows:EgoPose
with_ins=True
the converter initializesINSHandler
and load ego poses usingodometry
,imu
andnav_sat_fix
instead of/tf
message.INSHandler
retrieves an ego state interpolated by linear at the corresponding timestamp.The sample output of
ego_pose.json
is as below:VechileState
with_vechile_status=True
, the converter initializesVehicleStatusHandler
and load certain vehicle states.vehicle_state.json
are not associated with the other records such assample.json
.The sample output of
vehicle_state.json
is as below:How to review
How to test
test data
test command
input_base
in theconfig/convert_comlops_rosbag2_to_non_annotated_t4_sample.yaml
, run following command:Reference
Notes for reviewer