fix(velodyne): remove heavy get_snapshot from HW monitor

[mojomex]

PR Type

• Bug Fix

Related Links

• TIER IV INTERNAL -- the reported issue

Description

The /cgi/snapshot.hdl endpoint of the sensor is not meant to be polled every second. Doing that causes the sensor to sometimes drop communication for a while (see the linked issue above).

This hotfix removes the timer polling get_snapshot and the related, now unused code.
As far as I can tell, marking diag info stale did not work reliably before (updates from get_diag and get_status were ignored, and will not work at all now.
All diag information will still be output as before.

Review Procedure

Test with a real VLP16, VLP32 and VLS128 and compare before/after, especially with advanced diag enabled.

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

• Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

• Commits are properly organized and messages are according to the guideline
• (Optional) Unit tests have been written for new behavior
• PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

• All open points are addressed and tracked via issues or tickets

CI Checks

• Build and test for PR: Required to pass before the merge.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 26.57%. Comparing base (1128658) to head (4a385f8).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #279      +/-   ##
==========================================
- Coverage   29.28%   26.57%   -2.71%     
==========================================
  Files         112      112              
  Lines        9733     9489     -244     
  Branches     3252     2121    -1131     
==========================================
- Hits         2850     2522     -328     
- Misses       6359     6543     +184     
+ Partials      524      424     -100     

Flag	Coverage Δ
differential	26.57% <0.00%> (?)
total	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Common	18.37% <ø> (-31.87%)	⬇️
Hesai	29.69% <ø> (-0.72%)	⬇️
Velodyne	37.78% <0.00%> (+0.59%)	⬆️
Continental	25.09% <ø> (+0.02%)	⬆️
Robosense	0.00% <ø> (ø)

[interimadd]

Thank you for fixing issue for diagnostics.
I've added a single comment for a small suggestion, but totally looks great so I approved this PR.

[KYabuuchi]

Thanks for creating the fix PR!
I tested this fix using both the VLP-16 and VLS-128, and it looks good to me.