Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(velodyne): remove unused private variables from HW monitor #282

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

interimadd
Copy link

@interimadd interimadd commented Feb 26, 2025

PR Type

  • Refactor

Related Links

#279

Description

Some private variables in the Velodyne hardware monitor class were not being used.
Therefore, these variables have been removed.

Review Procedure

Please verify that the nebula_ros package compiles successfully using the following command:

colcon build --packages-up-to nebula_ros

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@interimadd interimadd changed the title refactor(velodyne): Remove unused private variables from HW monitor refactor(velodyne): remove unused private variables from HW monitor Feb 26, 2025
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.57%. Comparing base (b38ac0a) to head (4aa3d37).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #282      +/-   ##
==========================================
- Coverage   29.38%   26.57%   -2.81%     
==========================================
  Files         112      112              
  Lines        9699     9490     -209     
  Branches     3249     2121    -1128     
==========================================
- Hits         2850     2522     -328     
- Misses       6325     6544     +219     
+ Partials      524      424     -100     
Flag Coverage Δ
differential 26.57% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Common 18.37% <ø> (-31.87%) ⬇️
Hesai 29.69% <ø> (-0.72%) ⬇️
Velodyne 37.76% <ø> (+0.10%) ⬆️
Continental 25.09% <ø> (+0.02%) ⬆️
Robosense 0.00% <ø> (ø)

@interimadd interimadd requested a review from mojomex February 26, 2025 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant